Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36118

LDAP sync_users performs redundant actions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: None
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      When deciding whether to execute a block of code that deletes users, sync_users() uses incorrect comparison operator (trying to strictly compare a string with a numeral constant). This leads to redundant actions and performance deterioration.

      How to fix:
      in file auth/ldap/auth.php
      replace
      if ($this->config->removeuser !== AUTH_REMOVEUSER_KEEP) {
      with
      if ($this->config->removeuser != AUTH_REMOVEUSER_KEEP) {

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              badblock Kirill Astashov
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: