Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36119

ldap auth sync - add paged support

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Make sure you can run PHP 5.4 and PHP 5.3 - tests need to be done on both PHP versions. probably best to run on PHP 5.3 first.

      Make sure you have an LDAP store that has a high number of users (over 1000 in a single container)

      set Moodle ldap auth to connect to your LDAP as per usual and check to make sure login works correctly with a few accounts.
      with PHP 5.3
      run the CLI script /auth/ldap/cli/sync_users.php
      Not all ldap accounts will be transferred into Moodle (unless you've configured your ldap to return more than the usual number of records)
      Move to PHP 5.4
      run the CLI script again - it should create all the missing accounts that it previously missed.

      Test ldap enrolment.

      Show
      Make sure you can run PHP 5.4 and PHP 5.3 - tests need to be done on both PHP versions. probably best to run on PHP 5.3 first. Make sure you have an LDAP store that has a high number of users (over 1000 in a single container) set Moodle ldap auth to connect to your LDAP as per usual and check to make sure login works correctly with a few accounts. with PHP 5.3 run the CLI script /auth/ldap/cli/sync_users.php Not all ldap accounts will be transferred into Moodle (unless you've configured your ldap to return more than the usual number of records) Move to PHP 5.4 run the CLI script again - it should create all the missing accounts that it previously missed. Test ldap enrolment.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_master_mdl-36119_ldap_paged_results
    • Pull Master Diff URL:

      Description

      I couldn't find an existing open bug for this so if I've missed something let me know.

      LDAP in PHP has had a problem for ages that has meant that the sync process hasn't worked well. That bug has finally been fixed in PHP 5.4 so we should be able to implement a conditional fix for Moodle 2.4 at least.

      most of the work on this has been done already - we just need to port this for Moodle 2.4
      more info here:
      https://github.com/jcharaoui/moodle-cegep/wiki/PHP-LDAP-Paging

        Attachments

        1. mdl-36119-enrol-ldap-fix.patch
          2 kB
          Iñaki Arenaza

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37315 ldap paged results connection closing in find_ext_enrolments() is incorrect

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38262 Undefined property: stdClass::$ldap_version in HEAD/auth/ldap/auth.php on line 1739

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-10331 Enable enrol/ldap to page large courses

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              danmarsden Dan Marsden
              Reporter:
              danmarsden Dan Marsden
              Peer reviewer:
              Iñaki Arenaza
              Integrator:
              Dan Poltawski
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12