Moodle
  1. Moodle
  2. MDL-35816 Accessibility Review issues (Deque)
  3. MDL-36125

Course page edit activity title instructions for escape not spoken to the user

    Details

    • Testing Instructions:
      Hide
      1. Login as a teacher
      2. Enter editing mode and go to course
      3. Tab to the edit title icon for one of the activities in the course
      4. hit the enter key and listen to the screen reader (NVDA)
      5. make sure "Escape to cancel, Enter to finish" is read.

      Test 2:

      1. With firebug make sure text input (for editing label), has aria-describedby attribute, with value = id of span ("Escape to cancel, Enter to finish")
      Show
      Login as a teacher Enter editing mode and go to course Tab to the edit title icon for one of the activities in the course hit the enter key and listen to the screen reader (NVDA) make sure "Escape to cancel, Enter to finish" is read. Test 2: With firebug make sure text input (for editing label), has aria-describedby attribute, with value = id of span ("Escape to cancel, Enter to finish")
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-36125

      Description

      Issue
      Efficient labels - The instructions for what a user should do after they have entered the edit title area in a course for an activity does not read to a screen reader because it is not the focus. A non sighted user is not provided the instructions to hit escape to exit the text.

      Standard Level
      WCAG 2 3.3.2 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-minimize-error-cues

      Impact
      Serious

      Example Link
      http://demo.moodle.net/user/edit.php?id=5&course=1

      Test Steps

      1. Login as a teacher
      2. Enter editing mode
      3. Tab to the edit title icon for one of the activities in the course
      4. hit the enter key and listen to the screen reader
      5. Tab to required fields notice.

        Gliffy Diagrams

          Activity

          Hide
          Rajesh Taneja added a comment -

          Added aria-described by to read Escape information.

          Show
          Rajesh Taneja added a comment - Added aria-described by to read Escape information.
          Hide
          Ankit Agarwal added a comment -

          Hi Raj,
          Patch is spot on, submitting for integration.
          [y] Syntax
          [y] Output
          [y] Whitespace
          [na] Language
          [na] Databases
          [y] Testing
          [na] Security
          [na] Documentation
          [y] Git
          [y] Sanity check

          Thanks

          Show
          Ankit Agarwal added a comment - Hi Raj, Patch is spot on, submitting for integration. [y] Syntax [y] Output [y] Whitespace [na] Language [na] Databases [y] Testing [na] Security [na] Documentation [y] Git [y] Sanity check Thanks
          Hide
          Damyon Wiese added a comment -

          Patch looks good - I was concerned that the id might not be unique in the page, but there can only be one title edit form in the page at once so all good.

          Show
          Damyon Wiese added a comment - Patch looks good - I was concerned that the id might not be unique in the page, but there can only be one title edit form in the page at once so all good.
          Hide
          Damyon Wiese added a comment -

          Thanks Raj,

          All looks good. Integrated to 23, 24 and master.

          Show
          Damyon Wiese added a comment - Thanks Raj, All looks good. Integrated to 23, 24 and master.
          Hide
          Adrian Greeve added a comment -

          tested on 2.3, 2.4 and master integration branches.
          After some fooling around the text was read out. I think there might have been something wrong with my current set up. Some times it would work and other times it would not. I don't think this is an issue with the code, but rather with my windows installation.

          Show
          Adrian Greeve added a comment - tested on 2.3, 2.4 and master integration branches. After some fooling around the text was read out. I think there might have been something wrong with my current set up. Some times it would work and other times it would not. I don't think this is an issue with the code, but rather with my windows installation.
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: