Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-3613

grade_item not initialized properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: None
    • Component/s: Gradebook
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      In function grade_assign_categories, the extra_credit field is initialized to $cur_extra_credit, which may have the nonnumerical value on. Consequently the subsequent insert_record call fails.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Jeff Graham (jjg7 at humboldt.edu) Thursday, 7 July 2005, 04:04 AM:

          Due to the different ways that browsers submit checkbox values the submitted value can either be on, 1 or true in older netscape browsers. The variable usually isn't submitted if it is not checked. I reviewed the code and should be working fine. The value for $cur_extra_credit gets set in 2-stage process to try and capture all the different browser/OS combinations.

          fiedorow if you could provide more details; what OS, browser and version and if this actually happened or you were reviewing the code and saw a potential flaw.

          From Eloy Lafuente (stronk7 at moodle.org) Friday, 7 October 2005, 01:32 AM:

          Hi Fied, any news here? Or is this working fine?

          From Dan Marsden (dan at digitalclay.co.nz) Thursday, 8 June 2006, 05:22 PM:

          MDL-8 months old, - closing feel free to open if still having trouble.

          Show
          dougiamas Martin Dougiamas added a comment - From Jeff Graham (jjg7 at humboldt.edu) Thursday, 7 July 2005, 04:04 AM: Due to the different ways that browsers submit checkbox values the submitted value can either be on, 1 or true in older netscape browsers. The variable usually isn't submitted if it is not checked. I reviewed the code and should be working fine. The value for $cur_extra_credit gets set in 2-stage process to try and capture all the different browser/OS combinations. fiedorow if you could provide more details; what OS, browser and version and if this actually happened or you were reviewing the code and saw a potential flaw. From Eloy Lafuente (stronk7 at moodle.org) Friday, 7 October 2005, 01:32 AM: Hi Fied, any news here? Or is this working fine? From Dan Marsden (dan at digitalclay.co.nz) Thursday, 8 June 2006, 05:22 PM: MDL-8 months old, - closing feel free to open if still having trouble.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: