Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36138

Fix CAS Authentication Strict Standards warnings

    Details

    • Testing Instructions:
      Hide

      Pre-requisite:

      1. CAS and LDAP server configured to be used with moodle
      2. Enable debug developer mode

      TEST

      1. Log in as user who is not in moodle, but in CAS/LDAP.
      2. Make sure you don't see any php strict warnings.
      Show
      Pre-requisite: CAS and LDAP server configured to be used with moodle Enable debug developer mode TEST Log in as user who is not in moodle, but in CAS/LDAP. Make sure you don't see any php strict warnings.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36138-master

      Description

      When we first connect with our CAS Authentication method with the version 2.3.2 of Moodle those warning appears:

      Strict Standards: Non-static method phpCAS::client() should not be called statically, assuming $this from incompatible context in D:\xampp\htdocs\moodle\auth\cas\auth.php on line 190
       
      Strict Standards: Non-static method phpCAS::traceBegin() should not be called statically, assuming $this from incompatible context in D:\xampp\htdocs\moodle\auth\cas\CAS\CAS.php on line 345
       
      Strict Standards: Non-static method phpCAS::backtrace() should not be called statically, assuming $this from incompatible context in D:\xampp\htdocs\moodle\auth\cas\CAS\CAS.php on line 556

      Its only a short list but the problem is appear because of the function who are not called as public static function in the class phpCAS in auth/cas/CAS/CAS.php

      Another warning is about to not initialize the global var $frm in the function loginpage_hook() in auth/cas/auth.php like this:

      $frm = new stdClass();

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13