Moodle
  1. Moodle
  2. MDL-36162

Breadcrumbs in the message settings page are sometimes wrong

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      The correct breadcrumb is: Home > My profile settings > Messaging

      Go to your messaging settings from the course front page and from within a course and check that the breadcrumb is correct in both cases.

      Show
      The correct breadcrumb is: Home > My profile settings > Messaging Go to your messaging settings from the course front page and from within a course and check that the breadcrumb is correct in both cases.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      message_nav
    • Rank:
      44937

      Description

      If you go into a course then click on my profile settings > messaging the breadcrumb makes it look like you're editing your messaging settings within the course. In reality they are across the whole system.

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Adding a possible solution.

          Show
          Andrew Davis added a comment - Adding a possible solution.
          Hide
          Frédéric Massart added a comment -

          Hi Andrew,

          I like the solution provided and I think it makes a lot of sense. The only thing that I wonder is the navigation from another user point of view (teacher with moodle/user:editmessageprofile for example). They probably don't want to lose the navigation in the current course while editing a user's preference. Also if they're using someone else settings, $streditmymessage will not be accurate.

          What do you think?

          Cheers

          Show
          Frédéric Massart added a comment - Hi Andrew, I like the solution provided and I think it makes a lot of sense. The only thing that I wonder is the navigation from another user point of view (teacher with moodle/user:editmessageprofile for example). They probably don't want to lose the navigation in the current course while editing a user's preference. Also if they're using someone else settings, $streditmymessage will not be accurate. What do you think? Cheers
          Hide
          Andrew Davis added a comment -

          Im creating the 2.2 and 2.3 versions now.

          I'm not worried about a teacher (or whowever) being moved out of a course by accessing someone's messaging preferences. Once you're in the messaging system you are outside of a course. I'd rather the user be mildly annoyed at having to find their way back into a course rather than them falsely believing that they are modifying something course specific when they're actually modifying something that affects them site wide.

          I'm cleaning up the code around the string you mentioned. It actually only contains "Messaging" and there were two strings in the messaging lang file with that so Im removing one.

          Show
          Andrew Davis added a comment - Im creating the 2.2 and 2.3 versions now. I'm not worried about a teacher (or whowever) being moved out of a course by accessing someone's messaging preferences. Once you're in the messaging system you are outside of a course. I'd rather the user be mildly annoyed at having to find their way back into a course rather than them falsely believing that they are modifying something course specific when they're actually modifying something that affects them site wide. I'm cleaning up the code around the string you mentioned. It actually only contains "Messaging" and there were two strings in the messaging lang file with that so Im removing one.
          Hide
          Andrew Davis added a comment -

          Putting this up for peer review again.

          Show
          Andrew Davis added a comment - Putting this up for peer review again.
          Hide
          Frédéric Massart added a comment -

          Hi Andrew,

          I understand your point of view, and that's fair. I think we have two different approaches here. If I were a teacher, I'd prefer to still be in my course while editing my student's preferences, but that's just me.

          Before you submit for integration, just a little thing about the string change. I think you should not remove it from the stable branches. Also, do you think that 'editmymessage' might have been translated into something different than 'messaging' in some other languages? I can't think of anything, but as the string title is slightly different, I guess it could happen.

          Thanks!

          Show
          Frédéric Massart added a comment - Hi Andrew, I understand your point of view, and that's fair. I think we have two different approaches here. If I were a teacher, I'd prefer to still be in my course while editing my student's preferences, but that's just me. Before you submit for integration, just a little thing about the string change. I think you should not remove it from the stable branches. Also, do you think that 'editmymessage' might have been translated into something different than 'messaging' in some other languages? I can't think of anything, but as the string title is slightly different, I guess it could happen. Thanks!
          Hide
          Andrew Davis added a comment -

          "If I were a teacher, I'd prefer to still be in my course while editing my student's preferences"

          But you're not within the course. We were making it look like you were but as soon as you go to messaging you've left the course and are modifying site wide settings. Packaging it so it looks like you are within in a course is misleading.

          I have removed the string related commit from the 2.3 and 2.2 branches. You're correct, we should not remove strings from stable. Good catch.

          Submitting for integration.

          Show
          Andrew Davis added a comment - "If I were a teacher, I'd prefer to still be in my course while editing my student's preferences" But you're not within the course. We were making it look like you were but as soon as you go to messaging you've left the course and are modifying site wide settings. Packaging it so it looks like you are within in a course is misleading. I have removed the string related commit from the 2.3 and 2.2 branches. You're correct, we should not remove strings from stable. Good catch. Submitting for integration.
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
          Hide
          Mark Nelson added a comment -

          Works as expected. Passing.

          Show
          Mark Nelson added a comment - Works as expected. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: