-
Bug
-
Resolution: Fixed
-
Minor
-
2.3.2
-
MOODLE_23_STABLE
There's a bunch of individual bugs about this, which I'll try to find and link to this one but:
In Moodle Themes you have layout files that control the outer HTML of your site. If you change certain classnames then a variety of AJAX interactions throughout the site will silently fail.
Some possible solutions to this issues:
1. prominantly tell people that they aren't supposed to make any change the layout files in their theme.
2. prominantly tell people that if they change anything in the layout file then they should fully test all javascript based functionality, as some of it may silently break.
3. fully document all the dependencies so that themers can avoid accidentally breaking things.
4. rewrite the javascript so that it doesn't silently fail, but clearly informs you that some expected classname was missing
5. change the javascript so that it doesn't depend on anything that can be changed in the layout files.
You need #page-header and #page-footer for PDF (etc.) embedding to work as intended.
Hiding and showing activities via the eye icon on the course page can be broken too.
The Activity chooser window that replaces the two drop downs will not become an active link unless the correct CSS is found.
I personally would prefer some combination of the last two. I think most of the dependancies are attempts at optimisation that don't provide enough benefit to counterbalance the unexpected breakages as things change.
I'll try to find the other bugs that document these in detail, but for an overview:
- has a non-specific relationship to
-
MDL-34496 issue(s) with custom block regions
- Closed
-
MDL-35900 Blocks disappear when AJAX is enabled and editing is turned on
- Closed
-
MDL-33890 Drag n Drop does not work when moving blocks into custom regions
- Closed
-
MDL-24129 can't move blocks right side to left when all left blocks are docked.
- Closed
- is blocked by
-
MDL-26313 formal_white theme does not use standard page-header div
- Closed
-
MDL-34687 embedded object resizing javascript causing disappearing bug when HTML changed.
- Closed
- is duplicated by
-
MDL-38556 section-modchooser-text action/event listener only attached if in div#page-content
- Closed
- will be (partly) resolved by
-
MDL-35423 Activity chooser links and toolbox links not correctly created if you don't have a wrapper div called #page-content
- Closed
- will help resolve
-
MDL-38074 META: existing issues in Moodle core that affect Bootstrap
- Closed