Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36167

Feedback is deleted if grade is set to "No grade"

          Details

          • Testing Instructions:
            Hide
            1. Create an assignment with the Grade set to "No grade" and feedback comments enabled.
            2. Login as a teacher and go to the "View/grade all submissions" page
            3. Enable quickgrading
            4. Enter some text feedback in the quickgrading form and click "Save all quick grading changes"
            5. Click continue on the page which says "The grade changes were saved"
            6. The feedback text for the student should contain the updated value.
            Show
            Create an assignment with the Grade set to "No grade" and feedback comments enabled. Login as a teacher and go to the "View/grade all submissions" page Enable quickgrading Enter some text feedback in the quickgrading form and click "Save all quick grading changes" Click continue on the page which says "The grade changes were saved" The feedback text for the student should contain the updated value.
          • Workaround:
            Hide

            Create a grading scale with one entry: not graded activity
            Set the grading scale for the activity.

            Show
            Create a grading scale with one entry: not graded activity Set the grading scale for the activity.
          • Affected Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-36167-master
          • Pull Master Diff URL:

            Description

            If no grading is set in an assignment and teacher wants to change the feedback he made for an submission before the feedback field is empty if the grading page is re-opened. If the quick grading is active changes are not saved by using the save button.

            Replication steps:
            Use a course with students
            Create an assignment, set feedback comment to yes; set Grade to No grade

            Change grading to quick grading
            Add an entry feedback field
            Save your changes
            Change the entry in the feedback field
            Save your changes
            The entry is not saved.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37334 Assignment Outcomes Not Working with Quick Grading

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    salvetore Michael de Raadt added a comment -

                    Thanks for reporting that, Ralf.

                    I don't think that is a blocker issue, but it is major.

                    Please keep working on the issue with us.

                    Show
                    salvetore Michael de Raadt added a comment - Thanks for reporting that, Ralf. I don't think that is a blocker issue, but it is major. Please keep working on the issue with us.
                    Hide
                    Permalink
                    ralfh Ralf Hilgenstock added a comment -

                    Hi Michael

                    if data are lost if the page is opened again this should get higher priority. If data added to a form are not stored this should also get higher priority.

                    Show
                    ralfh Ralf Hilgenstock added a comment - Hi Michael if data are lost if the page is opened again this should get higher priority. If data added to a form are not stored this should also get higher priority.
                    Hide
                    Permalink
                    corleone Raymond Antonio added a comment -

                    Hi Damyon,
                    There is a patch for this bug on my Github link above ready for peer review. Thanks Damyon

                    Show
                    corleone Raymond Antonio added a comment - Hi Damyon, There is a patch for this bug on my Github link above ready for peer review. Thanks Damyon
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    The second issue also affects 2.4 (just tested).

                    Show
                    damyon Damyon Wiese added a comment - The second issue also affects 2.4 (just tested).
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Just looking at the patch for quickgrading and it does not do the correct thing - it disables the lastmodified check completely - but it should just be ensuring that the grademodified field is added to the form even if there is no grade.

                    I'll come up with another patch.

                    Show
                    damyon Damyon Wiese added a comment - Just looking at the patch for quickgrading and it does not do the correct thing - it disables the lastmodified check completely - but it should just be ensuring that the grademodified field is added to the form even if there is no grade. I'll come up with another patch.
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Also - some more feedback - your commit message was incorrect MDL-36167_M23: should just be MDL-36167: - I'll amend this.

                    Show
                    damyon Damyon Wiese added a comment - Also - some more feedback - your commit message was incorrect MDL-36167 _M23: should just be MDL-36167 : - I'll amend this.
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    These patches are ready - except I want to clarify the first issue listed in "Test a" in the description. This test does not fail for me before or after the patch (The feedback entered in the single grade page is saved and is displayed correctly when the page is re-opened - even if the grade for the assignment is set to "No grade" - tested on 2.3 and 2.4).

                    Can Raymond or Luke confirm that the first issue has not already been fixed and/or that the current patch addresses this issue?

                    Thanks - Damyon

                    Show
                    damyon Damyon Wiese added a comment - These patches are ready - except I want to clarify the first issue listed in "Test a" in the description. This test does not fail for me before or after the patch (The feedback entered in the single grade page is saved and is displayed correctly when the page is re-opened - even if the grade for the assignment is set to "No grade" - tested on 2.3 and 2.4). Can Raymond or Luke confirm that the first issue has not already been fixed and/or that the current patch addresses this issue? Thanks - Damyon
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Removing test A from the description as it did not fail for me and I don't think it is relevant to this patch.

                    Show
                    damyon Damyon Wiese added a comment - Removing test A from the description as it did not fail for me and I don't think it is relevant to this patch.
                    Hide
                    Permalink
                    corleone Raymond Antonio added a comment - - edited

                    Hi Damyon,
                    Apologise for a tardy response... just back from a week leave. No I can not reproduce the issue described in"Test a" and I confirm now the issues in test A and b have been fixed by the above patches. Thanks Damyon

                    Show
                    corleone Raymond Antonio added a comment - - edited Hi Damyon, Apologise for a tardy response... just back from a week leave. No I can not reproduce the issue described in"Test a" and I confirm now the issues in test A and b have been fixed by the above patches. Thanks Damyon
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Thanks Raymond

                    Show
                    damyon Damyon Wiese added a comment - Thanks Raymond
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Integrated to master, 24 and 23, thanks Damyon.

                    Show
                    poltawski Dan Poltawski added a comment - Integrated to master, 24 and 23, thanks Damyon.
                    Hide
                    Permalink
                    markn Mark Nelson added a comment -

                    Works as expected. Passing.

                    Show
                    markn Mark Nelson added a comment - Works as expected. Passing.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

                    Closing, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

                      People

                      • Votes:
                        6 Vote for this issue
                        Watchers:
                        6 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/Jan/13