Moodle
  1. Moodle
  2. MDL-36168

Saving SCORM completion: Can't uncheck Status requirement.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.4
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      enable activity completion at site level
      enable activity completion inside a course
      add a SCORM package to the course and enable course completion by setting the following:
      Completion tracking: Set to "when conditions are met"
      set require status to completed only (don't set any other conditions)
      save form.
      Re-enter editing settings page for the SCORM and unset require status checkbox
      Save form.
      JS validation should throw an error to state that you must set a condition if you want to use "when conditions are met"

      Show
      enable activity completion at site level enable activity completion inside a course add a SCORM package to the course and enable course completion by setting the following: Completion tracking: Set to "when conditions are met" set require status to completed only (don't set any other conditions) save form. Re-enter editing settings page for the SCORM and unset require status checkbox Save form. JS validation should throw an error to state that you must set a condition if you want to use "when conditions are met"
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      master_MDL-36168
    • Rank:
      44944

      Description

      To reproduce:

      1) In a Scorm activity, set it to require "Completed" status for activity completion and save.
      2) Go back to settings and uncheck the "Completed" requirement (and in our case, check "Student must view this activity to complete it", but I don't think that is necessary). Save.
      3) Go back into settings, see that "Completed" is still checked.

      Workaround:
      1) For #2 above, instead set it to not track completion, and save, when you come back you get a clean slate to work with.

      note: changing from "Completed" to "Passed" works, but you similarly can't subsequently uncheck "passed"

        Activity

        Hide
        Sam Marshall added a comment -

        (Assigning to SCORM activity owner; this is indeed a problem related to activity completion, but in this case, it's the SCORM module's part of the code.)

        Show
        Sam Marshall added a comment - (Assigning to SCORM activity owner; this is indeed a problem related to activity completion, but in this case, it's the SCORM module's part of the code.)
        Hide
        Dan Marsden added a comment -

        heh - that sounds like something I would have done... I've made that mistake before! - probably an easy fix, adding Aaron here as well FYI.

        I'll take a look when I get back from the Hackfest.

        Show
        Dan Marsden added a comment - heh - that sounds like something I would have done... I've made that mistake before! - probably an easy fix, adding Aaron here as well FYI. I'll take a look when I get back from the Hackfest.
        Hide
        Dan Marsden added a comment -

        Hey Aaron - any chance you might be able to peer review this one for me? - you might have seen the new checklist we're using during Peer review - more info on that here:
        http://docs.moodle.org/dev/Peer_reviewing_checklist

        Show
        Dan Marsden added a comment - Hey Aaron - any chance you might be able to peer review this one for me? - you might have seen the new checklist we're using during Peer review - more info on that here: http://docs.moodle.org/dev/Peer_reviewing_checklist
        Hide
        Aaron Barnes added a comment -

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [Y] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        Show
        Aaron Barnes added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [Y] Security [-] Documentation [Y] Git [Y] Sanity check
        Hide
        Dan Marsden added a comment -

        great - thanks Aaron!

        Show
        Dan Marsden added a comment - great - thanks Aaron!
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Thanks Dan, i've integrated this now (master and 23)

        Show
        Dan Poltawski added a comment - Thanks Dan, i've integrated this now (master and 23)
        Hide
        Ankit Agarwal added a comment -

        This works as described.
        passing
        Thanks

        Show
        Ankit Agarwal added a comment - This works as described. passing Thanks
        Hide
        Dan Poltawski added a comment -

        Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

        ciao
        Dan

        Show
        Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: