Moodle

Enrolled users sorting bug

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.2
  • Fix Version/s: 2.2.7, 2.3.4
  • Component/s: Enrolments
  • Labels:
    None
  • Testing Instructions:
    Hide

    0/ add some phone numbers to enrolled users
    1/ go to course enrolled users page in some course
    2/ try sorting by surname, email
    3/ manually modify the URL to sort by phone1 and phone2 - verify the records get sorted properly

    Show
    0/ add some phone numbers to enrolled users 1/ go to course enrolled users page in some course 2/ try sorting by surname, email 3/ manually modify the URL to sort by phone1 and phone2 - verify the records get sorted properly
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    w46_MDL-36169_m24_enrolsort
  • Pull Master Diff URL:

Description

Although both phone1 and phone2 are sorting options for the course_enrolment_manager class the sort parameter is limited to only alphabetical characters.

Line 420 to 434:

https://github.com/moodle/moodle/blob/master/enrol/renderer.php

  1. Text File
    renderer.patch
    23/Oct/12 2:29 AM
    0.7 kB
    Nicholas Koeppen

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nicholas Koeppen added a comment -

Including patch for fix of sorting parameter

Show
Nicholas Koeppen added a comment - Including patch for fix of sorting parameter
Hide
Permalink
Petr Škoda added a comment -

Thanks for the report and patch.

Show
Petr Škoda added a comment - Thanks for the report and patch.
Hide
Permalink
Dan Poltawski added a comment -

Please don't forget about 22_STABLE, its still in support.

Integrated to 22, 23 and master.

Show
Dan Poltawski added a comment - Please don't forget about 22_STABLE, its still in support. Integrated to 22, 23 and master.
Hide
Permalink
David Monllaó added a comment -

It passes. Tested in master and 23

Show
David Monllaó added a comment - It passes. Tested in master and 23
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many, many thanks for your effort!

Millions of people will enjoy the results of your work, yay!

Closing as fixed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: