Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36170

Database: Blocks editing button wrapped in <table> which interferes with theming

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Requirements

      • a user with course editing capabilities
      • a course with a Database activity module instance

      Instructions

      1. access a Moodle course as a user with editing capabilities and editing mode turned off
      2. access Database activity module instance
      3. using browser developer tools, inspect the element for the block that says Blocks editing on
      4. click on the Blocks editing on button
      5. using browser developer tools, inspect the element for the block that says Blocks editing off
      6. click on the Blocks editing off button

      Expected results

      • (2) – a button containing the text Blocks editing on should appear on the far right of the navigation bar
      • (3) – the button should be contained only within nested DIV elements (no TABLE HTML should be present around the block)
      • (4) – the page should reload and the block text should change to Blocks editing off and block editing controls should appear on any blocks already on the page. In addition, the Add a block block should appear on the page.
      • (5) – the button should be contained only within nested DIV elements (no TABLE HTML should be present around the block)
      • (6) – the page should reload and the block text should change to Blocks editing on and block editing controls should not appear on any of the blocks already on the page. The Add a block block should not appear on the page.
      Show
      Requirements a user with course editing capabilities a course with a Database activity module instance Instructions access a Moodle course as a user with editing capabilities and editing mode turned off access Database activity module instance using browser developer tools, inspect the element for the block that says Blocks editing on click on the Blocks editing on button using browser developer tools, inspect the element for the block that says Blocks editing off click on the Blocks editing off button Expected results (2) – a button containing the text Blocks editing on should appear on the far right of the navigation bar (3) – the button should be contained only within nested DIV elements (no TABLE HTML should be present around the block) (4) – the page should reload and the block text should change to Blocks editing off and block editing controls should appear on any blocks already on the page. In addition, the Add a block block should appear on the page. (5) – the button should be contained only within nested DIV elements (no TABLE HTML should be present around the block) (6) – the page should reload and the block text should change to Blocks editing on and block editing controls should not appear on any of the blocks already on the page. The Add a block block should not appear on the page.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36170_master

      Description

      In View List, View Single, and Search tabs of database module, Blocks editing on/off button is wrapped in a table. This increases the height of the navbar and requires targeted CSS fixes.

        Attachments

          Activity

            People

            Assignee:
            jfilip Justin Filip
            Reporter:
            agroshek Amy Groshek
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13