Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36171

db_replace should not update text on mdl_log

    Details

    • Testing Instructions:
      Hide

      On a test site (this is highly likely to trash your site):

      • [-] Perform some logged activities on your site (e.g. forum posts)
      • [ ] Check your mdl_log and note your IP
      • [-] Navigate to /admin/tool/replace/
      • [-] Rename from your IP to some other IP
      • [ ] Confirm that the log table was not listed in the generated SQL output
      • [ ] Confirm that your mdl_log table has not changed at all
      Show
      On a test site (this is highly likely to trash your site): [-] Perform some logged activities on your site (e.g. forum posts) [ ] Check your mdl_log and note your IP [-] Navigate to /admin/tool/replace/ [-] Rename from your IP to some other IP [ ] Confirm that the log table was not listed in the generated SQL output [ ] Confirm that your mdl_log table has not changed at all
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      mdl_log is often used for audit purposes. We shouldn't ever change it.
      Additionally, this makes renaming a site painfully slow

        Gliffy Diagrams

          Activity

          Hide
          danmarsden Dan Marsden added a comment -

          [Y] Syntax
          [-] Output
          [Y] Whitespace
          [-] Language
          [Y] Databases
          [Y] Testing
          [Y] Security
          [N] Documentation
          [Y] Git
          [Y] Sanity check

          I wonder if this would be a good opportunity to update the language strings & documentation on the page to provide info on which areas are ignored during the running of the script?

          Show
          danmarsden Dan Marsden added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [Y] Databases [Y] Testing [Y] Security [N] Documentation [Y] Git [Y] Sanity check I wonder if this would be a good opportunity to update the language strings & documentation on the page to provide info on which areas are ignored during the running of the script?
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Just updating this - is this what you had in mind?

          Show
          dobedobedoh Andrew Nicols added a comment - Just updating this - is this what you had in mind?
          Hide
          danmarsden Dan Marsden added a comment -

          looks good to me! +1

          Show
          danmarsden Dan Marsden added a comment - looks good to me! +1
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Recommend we don't backport this - no need for it.

          Show
          dobedobedoh Andrew Nicols added a comment - Recommend we don't backport this - no need for it.
          Hide
          damyon Damyon Wiese added a comment -

          This looks fine to me. +1

          Show
          damyon Damyon Wiese added a comment - This looks fine to me. +1
          Hide
          nebgor Aparup Banerjee added a comment -

          Thanks, thats been integrated into master now.

          about back-porting - agreed. Though, it would be good to note somewhere that the log table is more reliable for audits now, tagging.

          Show
          nebgor Aparup Banerjee added a comment - Thanks, thats been integrated into master now. about back-porting - agreed. Though, it would be good to note somewhere that the log table is more reliable for audits now, tagging.
          Hide
          dmonllao David Monllaó added a comment -

          It passes, no mdl_log sqls nor table changes

          Show
          dmonllao David Monllaó added a comment - It passes, no mdl_log sqls nor table changes
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13