Moodle
  1. Moodle
  2. MDL-36184

Changes in quick grading are updating date and time for all grades

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.1, 2.4
    • Fix Version/s: 2.3.4
    • Component/s: Assignment
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Create an assignment with feedback comments enabled in a course with more than one student
      2. Go to the grading page for the assignment
      3. Enable quickgrading
      4. Enter some feedback text for the last user
      5. Click "Save all quick grading changes"
      6. Click continue to get back to the grading page for the assignment
      7. Make a note of the time in the "Last modified (grade)" column for the user that was just modified.
      8. Wait at least one minute
      9. Enter some feedback text for the first user
      10. Click "Save all quick grading changes"
      11. Click continue to get back to the grading page for the assignment
      12. The last "Last modified (grade)" column for the last user should not have changed
      Show
      Create an assignment with feedback comments enabled in a course with more than one student Go to the grading page for the assignment Enable quickgrading Enter some feedback text for the last user Click "Save all quick grading changes" Click continue to get back to the grading page for the assignment Make a note of the time in the "Last modified (grade)" column for the user that was just modified. Wait at least one minute Enter some feedback text for the first user Click "Save all quick grading changes" Click continue to get back to the grading page for the assignment The last "Last modified (grade)" column for the last user should not have changed
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36184-master
    • Rank:
      44961

      Description

      If one or some grades are changed in the quick grading form the date of last change of grading is changed for all grades even for the grades that are not changed.
      Consistency of data is very relevant for all graded activity. If data are not stored correct, including the date that is created automatically it will create a lot of trouble for teachers

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Thanks Ralf - I have narrowed this down a bit more. If feedback comments are enabled, and the feedback for a submission is not blank, that submission will be modified whenever the quickgrading form is saved. This is confirmed on 2.4 as well.

          Show
          Damyon Wiese added a comment - Thanks Ralf - I have narrowed this down a bit more. If feedback comments are enabled, and the feedback for a submission is not blank, that submission will be modified whenever the quickgrading form is saved. This is confirmed on 2.4 as well.
          Hide
          Damyon Wiese added a comment -

          This was just a plain old bug. It was loading the grade for the wrong user and passing it to the feedback plugins to see if they had changed.

          Show
          Damyon Wiese added a comment - This was just a plain old bug. It was loading the grade for the wrong user and passing it to the feedback plugins to see if they had changed.
          Hide
          Damyon Wiese added a comment -

          Just updated the testing instructions

          Show
          Damyon Wiese added a comment - Just updated the testing instructions
          Hide
          Graham Bowman added a comment -

          I love it when a fix is so easy, but it's annoying how many times I've lost track of what has and hasn't been graded. Thankfully that shouldn't happen any more.

          Shouldn't this be integrated into 2.3.3+?

          Show
          Graham Bowman added a comment - I love it when a fix is so easy, but it's annoying how many times I've lost track of what has and hasn't been graded. Thankfully that shouldn't happen any more. Shouldn't this be integrated into 2.3.3+?
          Hide
          Damyon Wiese added a comment -

          Thanks Graham, I backported the patch for the 2.3 stable branch so it will go into 2.3 and 2.4 when it is integrated.

          Show
          Damyon Wiese added a comment - Thanks Graham, I backported the patch for the 2.3 stable branch so it will go into 2.3 and 2.4 when it is integrated.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Damyon.

          Show
          Dan Poltawski added a comment - Integrated, thanks Damyon.
          Hide
          Rossiani Wijaya added a comment -

          This is working as expected.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This is working as expected. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: