Moodle
  1. Moodle
  2. MDL-36196

T_PAAMAYIM_NEKUDOTAYIM in web based installer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.3
    • Component/s: Installation
    • Labels:
    • Rank:
      44975

      Description

      The exact required version was supposed to be shown by nice html, but developers keep forgetting that, so let's just hardcode the exact version at the start of installer and upgrade script.

        Activity

        Hide
        Petr Škoda added a comment -

        To integrators: I suppose it is enough to just review this, I personally do not have access to any older PHP version to test this.

        Show
        Petr Škoda added a comment - To integrators: I suppose it is enough to just review this, I personally do not have access to any older PHP version to test this.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Integrated to 23 and master, thanks!

        Show
        Dan Poltawski added a comment - Integrated to 23 and master, thanks!
        Hide
        Rossiani Wijaya added a comment - - edited

        Tested on 2.3, it works well.

        However, I unable to test for master due to this error (MDL-36454)

        Fatal error: Class 'cache' not found in /master/lib/moodlelib.php on line 6492 

        The error is not related to this patch but I'm unable to test this on master.

        Will notified integrators regarding this.

        Show
        Rossiani Wijaya added a comment - - edited Tested on 2.3, it works well. However, I unable to test for master due to this error ( MDL-36454 ) Fatal error: Class 'cache' not found in /master/lib/moodlelib.php on line 6492 The error is not related to this patch but I'm unable to test this on master. Will notified integrators regarding this.
        Hide
        Rossiani Wijaya added a comment -

        I followed the workaround as suggested in MDL-36454 and it installed perfectly.

        Re-tested on master and it works great.

        Test passed.

        Show
        Rossiani Wijaya added a comment - I followed the workaround as suggested in MDL-36454 and it installed perfectly. Re-tested on master and it works great. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

        (not really)

        Closing, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: