Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36197

PATCH Fusion theme, "Your progress" overlaps with checkbox if description is shown

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3.2
          • Fix Version/s: 2.2.6, 2.3.3
          • Component/s: Themes
          • Labels:
          • Testing Instructions:
            Hide
            1. select fusion theme
            2. go to a course page where course format is either topics or weeks and has completion tracking enabled
            3. TEST that Your progress help link is clear of the completion tracking check-box, for the first item, when there is no topic or weekly outline title visible.
            Show
            select fusion theme go to a course page where course format is either topics or weeks and has completion tracking enabled TEST that Your progress help link is clear of the completion tracking check-box, for the first item, when there is no topic or weekly outline title visible.
          • Difficulty:
            Easy
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE, MOODLE_23_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-36197_master
          • Pull Master Diff URL:

            Description

            The Your Progress span can overlap the checkbox as shown in the image if the first item has a description, making it two lines.
            Attached is a patch which sets clear: both on the topics block so that the floated text "Your Progress" doesn't intrude into it's space.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  Thanks for reporting this Rob, and for attaching a patch too.
                  Many thanks
                  Mary

                  Show
                  lazydaisy Mary Evans added a comment - Thanks for reporting this Rob, and for attaching a patch too. Many thanks Mary
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                  TIA and ciao

                  Show
                  poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  Rebased

                  Show
                  lazydaisy Mary Evans added a comment - Rebased
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Mary, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Mary, this has been integrated now.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Tested during integration review

                  Show
                  samhemelryk Sam Hemelryk added a comment - Tested during integration review
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  Hi Sam,
                  Is this too late to add a fix for Base theme too as I came across the same thing quite by chance the other day?

                  Show
                  lazydaisy Mary Evans added a comment - Hi Sam, Is this too late to add a fix for Base theme too as I came across the same thing quite by chance the other day?
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Hi Mary, too late on this issue sorry. Best you open a new issue for it

                  Many thanks
                  Sam

                  Show
                  samhemelryk Sam Hemelryk added a comment - Hi Mary, too late on this issue sorry. Best you open a new issue for it Many thanks Sam
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

                  (not really)

                  Closing, thanks!

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        12/Nov/12