XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: JavaScript, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Not much testing to be done really. Both versions are currently identical so only need to check that they loaded correctly.

      Check with both $this->yui3loader->combine set to true and false in lib/outputrequirements.php::get_yui3lib_headcode()

      • Open any page
      • Open the 'Network' tab of your developer tools
      • Refresh the page
      • Confirm that all of the YUI CSS libraries loaded correctly
        ------
        For theme designers:
      • try adding $THEME->yuicssmodules = array(); to your theme and verify that CSS does not get reset
      • try adding $THEME->yuicssmodules = array('cssnormalize'); and verify new normaliser is used instead
      Show
      Not much testing to be done really. Both versions are currently identical so only need to check that they loaded correctly. Check with both $this->yui3loader->combine set to true and false in lib/outputrequirements.php::get_yui3lib_headcode() Open any page Open the 'Network' tab of your developer tools Refresh the page Confirm that all of the YUI CSS libraries loaded correctly ------ For theme designers: try adding $THEME->yuicssmodules = array(); to your theme and verify that CSS does not get reset try adding $THEME->yuicssmodules = array('cssnormalize'); and verify new normaliser is used instead
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w12_MDL-36198_m25_yuireset

      Description

      See note at top of http://yuilibrary.com/yui/docs/cssreset/ and co:

      These shoudl really change to:
      cssbase/base.css -> cssbase/cssbase.css
      cssfonts/fonts.css -> cssfonts/cssfonts.css
      cssgrids/grids.css -> cssgrids/cssgrids.css
      cssreset/reset.css -> cssreset/cssreset.css

      We should be using cssreset/cssreset.css and cssbase/cssbase.css, etc instead.

      Not sure when these were deprecated - you can't view the documentation for previous YUI versions without downloading that version and passing it through docs :|

      That said, cssgrids.css is still in beta and cssbase has been causing themers issues. Do we actually need them?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13