Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31207 META: Collect together deprecated code changes for Moodle 2.5
  3. MDL-36198

Deprecated versions of YUI CSS libraries currently in use

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4
    • 2.5
    • JavaScript, Themes
    • MOODLE_24_STABLE
    • MOODLE_25_STABLE
    • w12_MDL-36198_m25_yuireset
    • Hide

      Not much testing to be done really. Both versions are currently identical so only need to check that they loaded correctly.

      Check with both $this->yui3loader->combine set to true and false in lib/outputrequirements.php::get_yui3lib_headcode()

      • Open any page
      • Open the 'Network' tab of your developer tools
      • Refresh the page
      • Confirm that all of the YUI CSS libraries loaded correctly
        ------
        For theme designers:
      • try adding $THEME->yuicssmodules = array(); to your theme and verify that CSS does not get reset
      • try adding $THEME->yuicssmodules = array('cssnormalize'); and verify new normaliser is used instead
      Show
      Not much testing to be done really. Both versions are currently identical so only need to check that they loaded correctly. Check with both $this->yui3loader->combine set to true and false in lib/outputrequirements.php::get_yui3lib_headcode() Open any page Open the 'Network' tab of your developer tools Refresh the page Confirm that all of the YUI CSS libraries loaded correctly ------ For theme designers: try adding $THEME->yuicssmodules = array(); to your theme and verify that CSS does not get reset try adding $THEME->yuicssmodules = array('cssnormalize'); and verify new normaliser is used instead

    Description

      See note at top of http://yuilibrary.com/yui/docs/cssreset/ and co:

      These shoudl really change to:
      cssbase/base.css -> cssbase/cssbase.css
      cssfonts/fonts.css -> cssfonts/cssfonts.css
      cssgrids/grids.css -> cssgrids/cssgrids.css
      cssreset/reset.css -> cssreset/cssreset.css

      We should be using cssreset/cssreset.css and cssbase/cssbase.css, etc instead.

      Not sure when these were deprecated - you can't view the documentation for previous YUI versions without downloading that version and passing it through docs :|

      That said, cssgrids.css is still in beta and cssbase has been causing themers issues. Do we actually need them?

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38391 Collect meta-data for YUI_config

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38507 YUI_config set up after SimpleYUI

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27774 HTML editor table border inconsistencies

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31331 TinyMCE and cellpadding attribute of table

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38016 Add a Moodle bootstrap theme to Moodle CORE

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27774 HTML editor table border inconsistencies

          • Major - Major loss of function, incorrect output
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38074 META: existing issues in Moodle core that affect Bootstrap

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              skodak Petr Skoda
              dobedobedoh Andrew Lyons
              Andrew Lyons Andrew Lyons
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Frédéric Massart Frédéric Massart
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/May/13