Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36204

moodle1 backup converter doesn't handle files with names containing spaces

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.1.8, 2.2.5, 2.3.2
    • 2.2.7, 2.3.4
    • Backup
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MDL-36204_master
    • Hide

      Restore the attached 1.9 backup (backup-mdl-36204-20121026-1201.zip) as a new course.
      Click both "This one" links in the label in the first section, and confirm that both files open correctly (i.e. neither of them results in the "Sorry, the requested file could not be found" message).

      Show
      Restore the attached 1.9 backup (backup-mdl-36204-20121026-1201.zip) as a new course. Click both "This one" links in the label in the first section, and confirm that both files open correctly (i.e. neither of them results in the "Sorry, the requested file could not be found" message).

    Description

      Neither the find_referenced_files function nor the migrate_referenced_files function bothers to urldecode the file paths that they work with, so file with names containing spaces (or any other character that gets urlencoded) won't be handled properly (the file won't make it into the correct file area, so the link just won't work).

      Attachments

        Activity

          People

            mudrd8mz David Mudrák (@mudrd8mz)
            paul.n Paul Nicholls
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Dan Poltawski Dan Poltawski
            Adrian Greeve Adrian Greeve
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              14/Jan/13