Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36204

moodle1 backup converter doesn't handle files with names containing spaces

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.8, 2.2.5, 2.3.2
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      Restore the attached 1.9 backup (backup-mdl-36204-20121026-1201.zip) as a new course.
      Click both "This one" links in the label in the first section, and confirm that both files open correctly (i.e. neither of them results in the "Sorry, the requested file could not be found" message).

      Show
      Restore the attached 1.9 backup (backup-mdl-36204-20121026-1201.zip) as a new course. Click both "This one" links in the label in the first section, and confirm that both files open correctly (i.e. neither of them results in the "Sorry, the requested file could not be found" message).
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36204_master
    • Pull Master Diff URL:

      Description

      Neither the find_referenced_files function nor the migrate_referenced_files function bothers to urldecode the file paths that they work with, so file with names containing spaces (or any other character that gets urlencoded) won't be handled properly (the file won't make it into the correct file area, so the link just won't work).

        Attachments

          Activity

            People

            Assignee:
            mudrd8mz David Mudrák (@mudrd8mz)
            Reporter:
            paul.n Paul Nicholls
            Peer reviewer:
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Adrian Greeve Adrian Greeve
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13