[MDL-36211] improve perf by not locking guest and not-logged-in sessions and skipping record updates when not necessary - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w47_~~MDL-36211~~_m24_sesslocking
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w47_MDL-36211_m24_sesslocking
Testing Instructions:

Hide

1/ try working with moodle as not-logged-in-user (mostly frontapge only)
2/ try working as guest
3/ try logging in, working, logging out, login in, ...
4/ enable new setting $CFG->sessionlockloggedinonly = 1; and repeat testing 1-3

Show
1/ try working with moodle as not-logged-in-user (mostly frontapge only) 2/ try working as guest 3/ try logging in, working, logging out, login in, ... 4/ enable new setting $CFG->sessionlockloggedinonly = 1; and repeat testing 1-3

I suppose it should be relatively safe to not lock guest and not-logged-in sessions.

I am going to implement it as a config.php only setting for now.

Discovered while testing

MDL-36743 bloglevel notice in web-based installation

has been marked as being related by

MDL-36675 Improve perf by not locking guest and not-logged-in sessions and skipping record updates when not necessary (backport of MDL-36211)

Participants:: Adrian Greeve, CiBoT, Dan Poltawski, Martin Dougiamas, Petr Skoda, Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo