[MDL-36212] Some forum mails not sent because of wrong html entity decoding - Moodle Tracker

Details

Testing Instructions:

Hide

1/ execute phpunit tests in PHP 5.3.2-3
2/ execute phpunit tests in PHP >= 5.3.4
3/ execute phpunit tests in PHP >= 5.4.0
—
4/ optionally verify GoogleSpellchecker is working for words with html entities
5/ optionally compose forum post in markdown format with unicode HTML entities and verify mailed plain text version

Show
1/ execute phpunit tests in PHP 5.3.2-3 2/ execute phpunit tests in PHP >= 5.3.4 3/ execute phpunit tests in PHP >= 5.4.0 — 4/ optionally verify GoogleSpellchecker is working for words with html entities 5/ optionally compose forum post in markdown format with unicode HTML entities and verify mailed plain text version
Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w51_~~MDL-36212~~_m25_entities
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w51_MDL-36212_m25_entities

The default charset of get_html_translation_table() is ISO-8859-1 for versions of PHP prior to 5.4.0 (http://php.net/manual/en/function.get-html-translation-table.php).

We've detected the problem because some forum emails (those with html entities) were not being sent because a database error (MySQL):

Incorrect string value: '\xA0\xA0\xA0\xA0\xA0\xA0...' for column 'fullmessage' at row 1

To fix the problem pass the encoding parameter to get_html_translation_table():

get_html_translation_table(HTML_ENTITIES, ENT_COMPAT|ENT_HTML401, 'utf-8');

Maybe other versions of moodle and other components are affected by this bug.

has a non-specific relationship to

MDL-37068 question format learnwise is not utf-8 compatible

	Duration	recent elements within time bar
		small	large
first row	weekly
	monthy
	quarterly
	yearly
second row	daily
	weekly
	monthy
	quarterly