Moodle
  1. Moodle
  2. MDL-36238

Cannot add blocks to Logs page using Blocks editing on

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Navigate to the Site Home
      3. Ensure editing is turned off
      4. Navigate to the Logs page using either:
        • Site pages > Reports > Logs
        • Settings > Site admin > Reports > Logs
      5. Click Blocks editing on
      6. Make sure you can add a block on log page
      Show
      Log in as admin Navigate to the Site Home Ensure editing is turned off Navigate to the Logs page using either: Site pages > Reports > Logs Settings > Site admin > Reports > Logs Click Blocks editing on Make sure you can add a block on log page
    • Workaround:
      Hide

      Turn editing on and off while for the Front page.

      Show
      Turn editing on and off while for the Front page.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-36238
    • Rank:
      45022

      Description

      It's not possible to add this block to the Logs page.

      Replication steps:

      1. Log in as admin
      2. Navigate to the Site Home
      3. Ensure editing is turned off
      4. Navigate to the Logs page using either:
        • Site pages > Reports > Logs
        • Settings > Site admin > Reports > Logs
      5. Click Blocks editing on button (Not "Turn editing on" link from navigation)
      6. Attempt to add a block

      Expected result: You should be able to add the block

      Actual result: Nothing is added, the editing mode turns itself off

      I couldn't find another page that has the same behaviour. I would have thought that the Statistics report, which has similar properties, would be the same, but it is not.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Hi, Ray.

          I was able to add the Admin bookmarks block on the Logs page (Settings > Site admin > Reports > Logs).

          Were you able to add any blocks on this page?

          Show
          Michael de Raadt added a comment - Hi, Ray. I was able to add the Admin bookmarks block on the Logs page (Settings > Site admin > Reports > Logs). Were you able to add any blocks on this page?
          Hide
          Ray Lawrence added a comment -

          Sadly not. But I notice that when I click on Reports > Logs my nav bar shows Home / ► Site pages / ► Reports / ► Logs / ► Reports / ► Logs

          Seeing the inability to add this block on various 2.2 and 2.3 sites

          OK on: Moodle 2.3.2 (Build: 20120910)
          Not on: Moodle 2.3.2+ (Build: 20121018) or Moodle 2.2.2 (Build: 20120312)

          Show
          Ray Lawrence added a comment - Sadly not. But I notice that when I click on Reports > Logs my nav bar shows Home / ► Site pages / ► Reports / ► Logs / ► Reports / ► Logs Seeing the inability to add this block on various 2.2 and 2.3 sites OK on: Moodle 2.3.2 (Build: 20120910) Not on: Moodle 2.3.2+ (Build: 20121018) or Moodle 2.2.2 (Build: 20120312)
          Hide
          Michael de Raadt added a comment -

          Hi, Ray.

          I am now able to replicate the problem with some specific steps. It seems I was turning on editing in a different way. I have added these steps to the description.

          I did note the duplication in the breadcrumbs. That also seems to affect the Statistics report page. I think this has to do with the fact that they appear in both the Settings and Navigation blocks. I will raise that as a separate issue.

          Show
          Michael de Raadt added a comment - Hi, Ray. I am now able to replicate the problem with some specific steps. It seems I was turning on editing in a different way. I have added these steps to the description. I did note the duplication in the breadcrumbs. That also seems to affect the Statistics report page. I think this has to do with the fact that they appear in both the Settings and Navigation blocks. I will raise that as a separate issue.
          Hide
          Rajesh Taneja added a comment -

          Adding this to current sprint.

          Show
          Rajesh Taneja added a comment - Adding this to current sprint.
          Hide
          Ray Lawrence added a comment -

          Thanks Michael.

          Show
          Ray Lawrence added a comment - Thanks Michael.
          Hide
          Rajesh Taneja added a comment -

          Session write is closed on logs index page before calling admin_externalpage_setup, which was trying to set $USER->editing in session.
          Best way IMO is to set it explicitly, before closing the session.

          Show
          Rajesh Taneja added a comment - Session write is closed on logs index page before calling admin_externalpage_setup, which was trying to set $USER->editing in session. Best way IMO is to set it explicitly, before closing the session.
          Hide
          Ankit Agarwal added a comment - - edited

          Hi Rajesh,
          The patch looks great and works as expected. However we have the same problem in live report (report/loglive). Imho, that should be taken care of in this issue as well, but if you want, please fix that in separate issue.

          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [na] Databases
          [y] Testing
          [na] Security
          [na] Documentation
          [y] Git
          [y] Sanity check

          Thanks

          Edit:- Loglive is working fine.

          Show
          Ankit Agarwal added a comment - - edited Hi Rajesh, The patch looks great and works as expected. However we have the same problem in live report (report/loglive). Imho, that should be taken care of in this issue as well, but if you want, please fix that in separate issue. [y] Syntax [y] Output [y] Whitespace [y] Language [na] Databases [y] Testing [na] Security [na] Documentation [y] Git [y] Sanity check Thanks Edit:- Loglive is working fine.
          Hide
          Rajesh Taneja added a comment -

          Thanks Ankit,

          As discussed, this is not an issue on live logs page, hence pushing for integration.

          Show
          Rajesh Taneja added a comment - Thanks Ankit, As discussed, this is not an issue on live logs page, hence pushing for integration.
          Hide
          Sam Hemelryk added a comment -

          Thanks Raj, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Raj, this has been integrated now
          Hide
          Sam Hemelryk added a comment -

          Tested during integration review and passed.

          Show
          Sam Hemelryk added a comment - Tested during integration review and passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: