Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36241

Typo fix in lib/filestorage/zip_archive.php should be backported

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Trivial Trivial
    • None
    • 2.2.6, 2.3.3
    • Files API
    • MOODLE_22_STABLE, MOODLE_23_STABLE

      Inside the commit to address the MDL-33710 issue,
      http://git.moodle.org/gw?p=moodle.git;a=commitdiff;h=79c966cf213af9501a08857596ad9f28a323cc0a#patch16, there is the fix for a typo in the zip_archive::open() method:

      @@ -87,7 +90,7 @@ class zip_archive extends file_archive {
               } else {
                   $this->za = null;
                   $this->archivepathname = null;
      -            $this->encooding       = 'utf-8';
      +            $this->encoding        = 'utf-8';
                   // TODO: maybe we should return some error info
                   return false;
               }

      I'm not sure but the lacking of this fix when an archive cannot be opened shouldn't cause a relevant problem in 2.3 as well as in 2.2.
      In any case I've filed this issue to let you keep care of such missing, if relevant.

            skodak Petr Skoda
            matteo Matteo Scaramuccia
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.