Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36255

Some gradebook elements do not support multilang filter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.7.8, 3.4.3, 3.5
    • Fix Version/s: 3.4.5, 3.5.2
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites 

      1. Add a second language pack to your Moodle instance, e.g. German ("de").
      2. Enable the "Multi-Language Content" filter for "Content and headings".

      Test

      1. In a course, in the gradebook, add a top level category named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Category'
      2. In the same course, in the gradebook, add a top level category named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Category 2'
      3. In the same course, in the gradebook, add a category with parent category 'EN Category' named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Subcategory'
      4. In the same course, in the gradebook, add a category with parent category 'EN Category 2' named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Subcategory 2'
      5. In the same course, in the gradebook, add a grade item named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Item'
      6. Confirm that in the Grade report, the Category and Item names are correctly shown regarding the selected page language.
      7. Add an assignment to the course.
      8. Confirm that in the Adding a new Assignment page, Grade section, int the Grade category select, the Category names are correctly shown regarding the selected page language.

      Testing site and course level scales and outcomes

      1. Set the language to enlish on your site.
      2. Enable multilang for content and headings at the site level
      3. Go to site admin and search 'outcomes'.
      4. Check the box next to 'enable outcomes' if not already checked, and save.
      5. Now, go to Site admininstration > grades > scales.
      6. Add a new scale with the name '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> site scale name'
      7. In the scales table confirm you see 'EN site scale name' as the name of the scale.
      8. Now go back to site admin and go to grades > outcomes
      9. Start creating a new outcome and on that page Confirm you see the scale listed in the select menu as 'EN site scale name'
      10. Set the outcome name to '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> site outcome name'
      11. In the outcomes table, confirm you see the full name 'EN site outcome name'
      12. Now, go to a new course
      13. Go to course settings > more
      14. Select filters and then disable multilang for the course
      15. Now, go to the course gradebook (Grades, in the nav drawer)
      16. Select the scales tab and hit 'Add a new scale' button
      17. Create a new scale with name '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> course scale name'
      18. In the resulting table view, Confirm you see under the 'custom scales' heading your course scale with the name 'DEEN course scale name' (no filter has applied)
      19. Confirm you see under the 'Standard scales' heading your site scale with the name 'EN site scale name' (the filter has been applied)
      20. Now click the outcomes tab and select 'edit outcomes' in the sub tabs.
      21. Click 'add a new outcome'
      22. Start creating a new outcome, setting the title to '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> course outcome name'
      23. Confirm you see both scales (DEEN.. and EN..) in the scales select menu
      24. select the 'DEEN course scale name' and save the outcome
      25. On th resulting table view confirm that under 'custom outcomes' you see the 'DEEN course outcome name' item (no filter has applied)
      26. Confirm that under the 'Standard outcomes' menu you see the 'EN site outcome name' item (the filter has applied)

      This change is covered by automated tests. It does, however, not resolve the multilang scales values issue, but the category name one.

      Show
      Prerequisites  Add a second language pack to your Moodle instance, e.g. German ("de"). Enable the "Multi-Language Content" filter for "Content and headings". Test In a course, in the gradebook, add a top level category named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Category' In the same course, in the gradebook, add a top level category named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Category 2' In the same course, in the gradebook, add a category with parent category 'EN Category' named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Subcategory' In the same course, in the gradebook, add a category with parent category 'EN Category 2' named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Subcategory 2' In the same course, in the gradebook, add a grade item named '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> Item' Confirm  that in the Grade report, the Category and Item names are correctly shown regarding the selected page language. Add an assignment to the course. Confirm that in the Adding a new Assignment page, Grade section, int the Grade category select, the Category names are correctly shown regarding the selected page language. Testing site and course level scales and outcomes Set the language to enlish on your site. Enable multilang for content and headings at the site level Go to site admin and search 'outcomes'. Check the box next to 'enable outcomes' if not already checked, and save. Now, go to Site admininstration > grades > scales. Add a new scale with the name '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> site scale name' In the scales table confirm you see 'EN site scale name' as the name of the scale. Now go back to site admin and go to grades > outcomes Start creating a new outcome and on that page Confirm you see the scale listed in the select menu as 'EN site scale name' Set the outcome name to '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> site outcome name' In the outcomes table, confirm you see the full name 'EN site outcome name' Now, go to a new course Go to course settings > more Select filters and then disable multilang for the course Now, go to the course gradebook (Grades, in the nav drawer) Select the scales tab and hit 'Add a new scale' button Create a new scale with name '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> course scale name' In the resulting table view, Confirm you see under the 'custom scales' heading your course scale with the name 'DEEN course scale name' (no filter has applied) Confirm you see under the 'Standard scales' heading your site scale with the name 'EN site scale name' (the filter has been applied) Now click the outcomes tab and select 'edit outcomes' in the sub tabs. Click 'add a new outcome' Start creating a new outcome, setting the title to '<span lang="de" class="multilang">DE</span><span lang="en" class="multilang">EN</span> course outcome name' Confirm you see both scales (DEEN.. and EN..) in the scales select menu select the 'DEEN course scale name' and save the outcome On th resulting table view confirm that under 'custom outcomes' you see the 'DEEN course outcome name' item (no filter has applied) Confirm that under the 'Standard outcomes' menu you see the 'EN site outcome name' item (the filter has applied) This change is covered by automated tests. It does, however, not resolve the multilang scales values issue, but the category name one.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_27_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-36255-master

      Description

      Multilang filter does not work in some gradebook elements:

      • If we define a Grade category name using multilang, it is not properly shown in the gradebook.
      • If we define a scale with multilang values, they are not properly shown in the combo, neither in the activity nor in the gradebook.

      Our institution works in a multilingual environment and therefore, its important to show the gradebook in the language selected by the student

      This issue was already reported in http://tracker.moodle.org/browse/MDL-21498

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours
                  2h