[MDL-36259] Some pages does not display the course short name even if "Display extended course names" setting is on. - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.2
Fix Version/s: 2.3.4, 2.4.1
Component/s: Administration, Libraries
Labels:
- patch
- triaged

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-36259~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-36259
Testing Instructions:

Hide

Please test on all DBs. Particularly oracle.

Turn on the setting "Display extended course names" setting on Site administration > Appearance > Courses.

Go these page URLs:
1) /user/profile.php - View a user's course-specific profile page.
2) /user/view.php - View a user's full profile page.

For (1) and (2) the user profile will be displayed and the "Course profiles" field should list courses with the shortname as the prefix.

3) /enrol/meta/addinstance.php (Enable the course meta enrolment method then add it to a course)

The dropdown list of courses should list courses with the shortname as the prefix.

4) /course/search.php?modulelist... - Go to Admin -> Plugins -> Manage activities, and click on the link that tells you there are n forums, to see which courses those forums are in.
5) /course/search.php?blocklist... - Similar, but for blocks.

For (4) and (5) the list of courses should display with the shortname as the prefix when in editing is turned on.

6) /report/log/index.php - the logs report - site-wide, course or activity.

The dropdown course select lists display courses with the shortname as the prefix.

Show
Please test on all DBs. Particularly oracle. Turn on the setting "Display extended course names" setting on Site administration > Appearance > Courses. Go these page URLs: 1) /user/profile.php - View a user's course-specific profile page. 2) /user/view.php - View a user's full profile page. For (1) and (2) the user profile will be displayed and the "Course profiles" field should list courses with the shortname as the prefix. 3) /enrol/meta/addinstance.php (Enable the course meta enrolment method then add it to a course) The dropdown list of courses should list courses with the shortname as the prefix. 4) /course/search.php?modulelist... - Go to Admin -> Plugins -> Manage activities, and click on the link that tells you there are n forums, to see which courses those forums are in. 5) /course/search.php?blocklist... - Similar, but for blocks. For (4) and (5) the list of courses should display with the shortname as the prefix when in editing is turned on. 6) /report/log/index.php - the logs report - site-wide, course or activity. The dropdown course select lists display courses with the shortname as the prefix.

Description

This issue reports and provides the fix to improve on the work done in ~~MDL-34704~~.

A few admin screens display course fullname that does not respect the setting "Display extended course names" setting on Site administration > Appearance > Courses.

I went through the Moodle site/code and found 4 areas of the site to modify and improve:
1) When viewing user profile, the course profiles field does not respect the setting (/user/profile.php and /user/view.php)
2) Course metadata link page's dropdown (/enrol/instances.php)
3) The pages that list the courses a module or block is found in (/moodle/course/search.php?modulelist... and /course/search.php?blocklist....)
4) The course dropdown filter when viewing logs (/report/log/index.php)

Attachments

Issue Links

Discovered while testing

MDL-37115 context_helper::preload_from_record does not return the new context

Closed

has a non-specific relationship to

MDL-37558 Display the course short name for more pages "Display extended course names" setting is on.

Closed

is a regression caused by

MDL-34704 context_course::get_context_name should respect $CFG->courselistshortnames

Closed

Activity

People

Assignee:: Thanh Le

Reporter:: Thanh Le

Peer reviewer:: Tim Hunt

Integrator:: Dan Poltawski

Tester:: Damyon Wiese

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Michael de Raadt, Thanh Le, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 30/Oct/12 6:52 AM

Updated:: 21/Jan/13 9:50 AM

Resolved:: 21/Dec/12 5:24 PM

Fix Release Date:: 14/Jan/13