Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36266

Update notifications email should mention the site in the subject

    Details

    • Testing Instructions:
      Hide

      Testing difficulty: Hard (requires fake web service response)

      To test this, the tester would need to invoke sending available updates notification via messaging API and have the admin's messaging set to receive such messages to email.

      It is doable via $CFG->alternativeupdateproviderurl pointing to a local script that returns fake update data. I have this set up at my machine and I already tested it. I'm not sure if putting down all the instructions to prepare such an environment are worth of testing this trivial string change.

      Show
      Testing difficulty: Hard (requires fake web service response) To test this, the tester would need to invoke sending available updates notification via messaging API and have the admin's messaging set to receive such messages to email. It is doable via $CFG->alternativeupdateproviderurl pointing to a local script that returns fake update data. I have this set up at my machine and I already tested it. I'm not sure if putting down all the instructions to prepare such an environment are worth of testing this trivial string change.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36266-notification-subject

      Description

      If you have more than one site, or even just one site, then the email you get with just "Update notifications" in the subject is less than useful as it doesn't even tell you it's Moodle. This would be better:

      Subject: Moodle updates are available (http://mymoodle.edu)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            mudrd8mz David Mudrak added a comment -

            I realized there was even the string for the subject called 'updatenotificationsubject' (in lang/en/admin.php) that was not used though.

            So I just tweaked the existing string and made sure it is used what triggering the message event.

            DEAR INTEGRATORS,

            Even though this patch introduces a new $a placeholder into an existing string, I believe we can make an exception and back-port this safely into 2.3. Even if some language pack has the string translated, this change will not negatively affect the usability (admins will just see the old text without the site URL). And AMOS will report the existing translation outdated.

            Show
            mudrd8mz David Mudrak added a comment - I realized there was even the string for the subject called 'updatenotificationsubject' (in lang/en/admin.php) that was not used though. So I just tweaked the existing string and made sure it is used what triggering the message event. DEAR INTEGRATORS, Even though this patch introduces a new $a placeholder into an existing string, I believe we can make an exception and back-port this safely into 2.3. Even if some language pack has the string translated, this change will not negatively affect the usability (admins will just see the old text without the site URL). And AMOS will report the existing translation outdated.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks David, i've integrated this to 23 and master. I agree with your assessment about the lang string change.

            Show
            poltawski Dan Poltawski added a comment - Thanks David, i've integrated this to 23 and master. I agree with your assessment about the lang string change.
            Hide
            poltawski Dan Poltawski added a comment -

            Passing the test based on Davids comments.

            Show
            poltawski Dan Poltawski added a comment - Passing the test based on Davids comments.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

            (not really)

            Closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12