Moodle
  1. Moodle
  2. MDL-36271

Typo of variable name in feedback module.

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.2.5, 2.3.2
        • Fix Version/s: 2.2.6, 2.3.3
        • Component/s: Feedback
        • Labels:
        • Testing Instructions:
          Hide
          1. Visit a course and add the recent activity block if it is not there.
          2. Add a feedback activity.
          3. Click on 'Full report of recent activity...' in the recent activity block.
          4. Ensure you do not get the error 'Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php'.
          Show
          Visit a course and add the recent activity block if it is not there. Add a feedback activity. Click on 'Full report of recent activity...' in the recent activity block. Ensure you do not get the error 'Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php'.
        • Affected Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-36271_master
        • Pull Master Diff URL:

          Description

          When visiting a course that contains a feedback module and clicking to view 'Full report of recent activity...' on the 'Recent activity' block the following PHP error occurs.

          Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php on line 400

            Gliffy Diagrams

              Issue Links

              Testing discovered

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30377 RSS feed picks up expired (hidden) forum posts

              • Critical - Crashes server, loss of data, severe memory leak
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Michael de Raadt added a comment -

                I couldn't track this back to an issue, but this seems to have been last changed back in April 2010.

                Show
                Michael de Raadt added a comment - I couldn't track this back to an issue, but this seems to have been last changed back in April 2010.
                Hide
                Permalink
                Rajesh Taneja added a comment -

                Patch looks good Mark,

                Please add testing instructions before pushing it for integration review.
                [y] Syntax
                [-] Output
                [y] Whitespace
                [-] Language
                [-] Databases
                [-] Testing
                [-] Security
                [-] Documentation
                [y] Git
                [y] Sanity check

                Show
                Rajesh Taneja added a comment - Patch looks good Mark, Please add testing instructions before pushing it for integration review. [y] Syntax [-] Output [y] Whitespace [-] Language [-] Databases [-] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
                Hide
                Permalink
                Mark Nelson added a comment -

                Thanks Raj, done. Submitted for integration.

                Show
                Mark Nelson added a comment - Thanks Raj, done. Submitted for integration.
                Hide
                Permalink
                Dan Poltawski added a comment -

                The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                TIA and ciao

                Show
                Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks Mark, this has been integrated now

                Show
                Sam Hemelryk added a comment - Thanks Mark, this has been integrated now
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Tested and passed thanks.

                Show
                Sam Hemelryk added a comment - Tested and passed thanks.
                Hide
                Permalink
                Mark Nelson added a comment -

                Thanks Sam, was a massive patch. Took a few days, glad it was able to get through.

                Show
                Mark Nelson added a comment - Thanks Sam, was a massive patch. Took a few days, glad it was able to get through.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

                (not really)

                Closing, thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: