Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36271

Typo of variable name in feedback module.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Visit a course and add the recent activity block if it is not there.
      2. Add a feedback activity.
      3. Click on 'Full report of recent activity...' in the recent activity block.
      4. Ensure you do not get the error 'Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php'.
      Show
      Visit a course and add the recent activity block if it is not there. Add a feedback activity. Click on 'Full report of recent activity...' in the recent activity block. Ensure you do not get the error 'Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php'.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-36271_master

      Description

      When visiting a course that contains a feedback module and clicking to view 'Full report of recent activity...' on the 'Recent activity' block the following PHP error occurs.

      Undefined property: cm_info::$instace in /var/www/mstorage/s22/moodle/mod/feedback/lib.php on line 400

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              I couldn't track this back to an issue, but this seems to have been last changed back in April 2010.

              Show
              salvetore Michael de Raadt added a comment - I couldn't track this back to an issue, but this seems to have been last changed back in April 2010.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Patch looks good Mark,

              Please add testing instructions before pushing it for integration review.
              [y] Syntax
              [-] Output
              [y] Whitespace
              [-] Language
              [-] Databases
              [-] Testing
              [-] Security
              [-] Documentation
              [y] Git
              [y] Sanity check

              Show
              rajeshtaneja Rajesh Taneja added a comment - Patch looks good Mark, Please add testing instructions before pushing it for integration review. [y] Syntax [-] Output [y] Whitespace [-] Language [-] Databases [-] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
              Hide
              markn Mark Nelson added a comment -

              Thanks Raj, done. Submitted for integration.

              Show
              markn Mark Nelson added a comment - Thanks Raj, done. Submitted for integration.
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Mark, this has been integrated now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Mark, this has been integrated now
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Tested and passed thanks.

              Show
              samhemelryk Sam Hemelryk added a comment - Tested and passed thanks.
              Hide
              markn Mark Nelson added a comment -

              Thanks Sam, was a massive patch. Took a few days, glad it was able to get through.

              Show
              markn Mark Nelson added a comment - Thanks Sam, was a massive patch. Took a few days, glad it was able to get through.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

              (not really)

              Closing, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12