Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to the the calendar
      3. Click manage subscription
      4. Use the URL for an online ical to subscribe to it (if you need an ical feed check out http://www.icalshare.com/)
      5. Once set up browse back to the calendar
      6. Find a day containing a new event and browse to the day so that you can see event details.
      7. Check that the event is not editable (no little edit icon).
      Show
      Log in as an admin Browse to the the calendar Click manage subscription Use the URL for an online ical to subscribe to it (if you need an ical feed check out http://www.icalshare.com/ ) Once set up browse back to the calendar Find a day containing a new event and browse to the day so that you can see event details. Check that the event is not editable (no little edit icon).
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36276-m24
    • Rank:
      45062

      Description

      When events are imported from an iCal feed (new feature from MDL-16660 only just integrated) they must not be editable by users, else when the feed is next updated the change will be overwritten.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Upgrading to blocker as this is really a 'release blocker'.

          Show
          Dan Poltawski added a comment - Upgrading to blocker as this is really a 'release blocker'.
          Hide
          Rajesh Taneja added a comment -

          Sorry wrong issue

          Show
          Rajesh Taneja added a comment - Sorry wrong issue
          Hide
          Helen Foster added a comment -

          QA test master copy: MDLQA-4581

          Show
          Helen Foster added a comment - QA test master copy: MDLQA-4581
          Hide
          Ankit Agarwal added a comment -

          Also there should be a way to distinguish between different events from different subscription. If there are like 5 streams, I should be able to distinguish between the events created by each one of them.

          Show
          Ankit Agarwal added a comment - Also there should be a way to distinguish between different events from different subscription. If there are like 5 streams, I should be able to distinguish between the events created by each one of them.
          Hide
          Sam Hemelryk added a comment -

          Pushing up for peer-review.

          This change simple and only removes the ability to edit/delete entries associated with a subscription. Whether it is URL or file.

          If/when this gets accepted and integrated I'll create a new issue to properly look at this area.
          We should be able to edit/delete entries from file imports.
          We should also be showing information (even just the name) of the subscription somewhere when viewing an event.
          Having a page to view the entries associated with a subscription would also be a nice feature... the list goes on.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Pushing up for peer-review. This change simple and only removes the ability to edit/delete entries associated with a subscription. Whether it is URL or file. If/when this gets accepted and integrated I'll create a new issue to properly look at this area. We should be able to edit/delete entries from file imports. We should also be showing information (even just the name) of the subscription somewhere when viewing an event. Having a page to view the entries associated with a subscription would also be a nice feature... the list goes on. Cheers Sam
          Hide
          Rajesh Taneja added a comment -

          Patch looks good Sam,

          I agree we should lock events for url, but should we consider having a lock option for file import? As this might help in syncing events both way. Especially for files import/export.

          Please add testing instructions, before pushing it for integration.

          Show
          Rajesh Taneja added a comment - Patch looks good Sam, I agree we should lock events for url, but should we consider having a lock option for file import? As this might help in syncing events both way. Especially for files import/export. Please add testing instructions, before pushing it for integration.
          Hide
          Dan Poltawski added a comment -

          If you re-import a file it'll be modified in the same way, so I think that it should be locked.

          Show
          Dan Poltawski added a comment - If you re-import a file it'll be modified in the same way, so I think that it should be locked.
          Hide
          Ankit Agarwal added a comment -

          Adding this issue to the ical meta.
          Thanks

          Show
          Ankit Agarwal added a comment - Adding this issue to the ical meta. Thanks
          Hide
          Dan Poltawski added a comment -

          Taking this one into integration with basic testing instructions (as Sam is under weather today)

          Show
          Dan Poltawski added a comment - Taking this one into integration with basic testing instructions (as Sam is under weather today)
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan, was just going through my tracker list from yesterday, glad to see are already onto it!

          Show
          Sam Hemelryk added a comment - Thanks Dan, was just going through my tracker list from yesterday, glad to see are already onto it!
          Hide
          Dan Poltawski added a comment -

          Actually I didn't get round to it yet, so if you can do the testing instructions, it might speed it up

          Show
          Dan Poltawski added a comment - Actually I didn't get round to it yet, so if you can do the testing instructions, it might speed it up
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan, testing instructions added.

          Show
          Sam Hemelryk added a comment - Thanks Dan, testing instructions added.
          Hide
          Dan Poltawski added a comment -

          Thanks Sam, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Sam, i've integrated this now.
          Hide
          Dan Poltawski added a comment -

          Looks good here

          Show
          Dan Poltawski added a comment - Looks good here
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many, many thanks for your effort!

          Millions of people will enjoy the results of your work, yay!

          Closing as fixed. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: