[MDL-36277] Redesign activity icons in svg and png formats - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.2
Fix Version/s: 2.4
Component/s: Usability
Labels:
- triaged

Testing Instructions:
Hide

Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange.

Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons

log on

click "turn editing on"

click "add an activity or resource"

refer to the attached screenshot above to see what to expect for each icon visually

zoom out (ctrl +) to the max the activity chooser window to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format in 72ppi

check the course page as well if it is showing the icons properly
Show
Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange. Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons log on click "turn editing on" click "add an activity or resource" refer to the attached screenshot above to see what to expect for each icon visually zoom out (ctrl +) to the max the activity chooser window to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format in 72ppi check the course page as well if it is showing the icons properly
Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/barbararamiro/moodle.git
Pull Master Branch:
wip-~~MDL-36277~~-master
Pull Master Diff URL:
https://github.com/barbararamiro/moodle/compare/wip-MDL-36277-master

Description

Redesign activity icons in svg and png formats

Gliffy Diagrams

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

ActivitiesOverlapping_and_EditsectionActivitesGap_anomaly.png
36 kB
07/Nov/12 5:07 PM
new-activity-icons.png
56 kB
02/Nov/12 10:59 AM
Screen Shot 2012-11-06 at 15.02.23.png
18 kB
06/Nov/12 3:04 PM

Issue Links

Discovered while testing

MDL-36443 Consistency across icons when themes override some, but not all, standard icons

Open

MDL-36440 Padding between activites with new SVG & PNG icons

Closed

MDL-36441 No gap between the edit section icon and the section activities in some themes

Closed

MDL-36442 Blocks header color of Boxxie theme doesn't get along with new grey icons

Closed

MDL-36446 Resources icon of block activities (f/html)

Closed

MDL-36290 Outputlib post_process does not revert $usesvg

Closed

Show 1 more links (1 Discovered while testing)

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Barbara Ramiro added a comment - 01/Nov/12 11:42 AM

attached is the screenshot of the new set of activity icons

Show

Barbara Ramiro added a comment - 01/Nov/12 11:42 AM attached is the screenshot of the new set of activity icons

Hide

Permalink

Michael de Raadt added a comment - 02/Nov/12 10:08 AM

I just noted that the icon for Choice looks like a folder in your screen capture.

Show

Michael de Raadt added a comment - 02/Nov/12 10:08 AM I just noted that the icon for Choice looks like a folder in your screen capture.

Hide

Permalink

Barbara Ramiro added a comment - 02/Nov/12 10:59 AM

Thanks Michael. Here is a screenshot from the actual branch, replacing the previous screenshot to avoid confusion.

Show

Barbara Ramiro added a comment - 02/Nov/12 10:59 AM Thanks Michael. Here is a screenshot from the actual branch, replacing the previous screenshot to avoid confusion.

Hide

Permalink

Dan Poltawski added a comment - 06/Nov/12 3:03 PM

Thanks Barbara, thats been integrated now.

Show

Dan Poltawski added a comment - 06/Nov/12 3:03 PM Thanks Barbara, thats been integrated now.

Hide

Permalink

Dan Poltawski added a comment - 06/Nov/12 3:04 PM

I've spotted one problem during integration testing. The icon for a 'resource' when its off unknown type seems wrong.

I'm holding off creating an issue for this right now until this has had a testing iteration. See above screenshot.

Show

Dan Poltawski added a comment - 06/Nov/12 3:04 PM I've spotted one problem during integration testing. The icon for a 'resource' when its off unknown type seems wrong. I'm holding off creating an issue for this right now until this has had a testing iteration. See above screenshot.

Hide

Permalink

David Monllaó added a comment - 07/Nov/12 8:56 AM

Hi Andrew,

I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.

Show

David Monllaó added a comment - 07/Nov/12 8:56 AM Hi Andrew, I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.

Hide

Permalink

David Monllaó added a comment - 07/Nov/12 5:12 PM - edited

Tested in:

Android 4.x (Chrome, Firefox and built-in browser)
Android 2.3 (Firefox and built-in browser)
iPhone (Safari)
iPad (Safari)
Linux (Firefox and Chrome)
Windows (IE9 and Firefox)

Things to report:

~~MDL-36290~~ problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg
'navigationitem' image of the navigation block (visible for example inside 'Question bank' items) is still a pixel image (http://tracker.moodle.org/browse/MDL-36398)
Big activity icons in navigation block (http://tracker.moodle.org/browse/MDL-36323)
Resources icon in activities block (http://tracker.moodle.org/browse/MDL-36446)
Some themes overrides the standard themes icons, there is a mix of icon formats
There is no gap between the edit section icon and the section activities in the following themes: arialist, anomaly, binarius, boxxie, canvas, formfactor, leatherbound, magazine, nimble, nonzero, serenity, sky_high and splash (anomaly image attached)
There is a little overlapping between activity icons in sections in the following themes: fusion and anomaly (anomaly image attached)
In boxxie theme, the block editing icons are a bit dark for that dark green

Show

David Monllaó added a comment - 07/Nov/12 5:12 PM - edited Tested in: Android 4.x (Chrome, Firefox and built-in browser) Android 2.3 (Firefox and built-in browser) iPhone (Safari) iPad (Safari) Linux (Firefox and Chrome) Windows (IE9 and Firefox) Things to report: MDL-36290 problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg 'navigationitem' image of the navigation block (visible for example inside 'Question bank' items) is still a pixel image ( http://tracker.moodle.org/browse/MDL-36398 ) Big activity icons in navigation block ( http://tracker.moodle.org/browse/MDL-36323 ) Resources icon in activities block ( http://tracker.moodle.org/browse/MDL-36446 ) Some themes overrides the standard themes icons, there is a mix of icon formats There is no gap between the edit section icon and the section activities in the following themes: arialist, anomaly, binarius, boxxie, canvas, formfactor, leatherbound, magazine, nimble, nonzero, serenity, sky_high and splash (anomaly image attached) There is a little overlapping between activity icons in sections in the following themes: fusion and anomaly (anomaly image attached) In boxxie theme, the block editing icons are a bit dark for that dark green

Hide

Permalink

David Monllaó added a comment - 08/Nov/12 10:55 AM

After talking with Barbara and Dan we pass the issue and create new issues with the related problems. Linking remaining issues

Show

David Monllaó added a comment - 08/Nov/12 10:55 AM After talking with Barbara and Dan we pass the issue and create new issues with the related problems. Linking remaining issues

Hide

Permalink

Mary Evans added a comment - 08/Nov/12 6:57 PM

I'm trying to fix the themes but after updating Moodle I still don't see the new icons. Am I missing something here?

Show

Mary Evans added a comment - 08/Nov/12 6:57 PM I'm trying to fix the themes but after updating Moodle I still don't see the new icons. Am I missing something here?

Hide

Permalink

Mary Evans added a comment - 08/Nov/12 7:06 PM

Sorry...my brain must be in nuetral...disregard my last comment, I've just realised my mistake.

Show

Mary Evans added a comment - 08/Nov/12 7:06 PM Sorry...my brain must be in nuetral...disregard my last comment, I've just realised my mistake.

Hide

Permalink

Dan Poltawski added a comment - 08/Nov/12 7:13 PM

Hi Mary, just making sure you're seening the work going on in the subtasks too.

Show

Dan Poltawski added a comment - 08/Nov/12 7:13 PM Hi Mary, just making sure you're seening the work going on in the subtasks too.

Hide

Permalink

Mary Evans added a comment - 08/Nov/12 8:55 PM

When I get to commit these which version of Moodle should I be using? Currently it's 2012110101.00 which was last time I updated.

Also are these ALL the new icons on the QA site? Will make it easier to see the problems as a whole if they are.

Show

Mary Evans added a comment - 08/Nov/12 8:55 PM When I get to commit these which version of Moodle should I be using? Currently it's 2012110101.00 which was last time I updated. Also are these ALL the new icons on the QA site? Will make it easier to see the problems as a whole if they are.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 10/Nov/12 1:11 AM

Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

(not really)

Closing, thanks!

Show

Eloy Lafuente (stronk7) added a comment - 10/Nov/12 1:11 AM Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

People

Assignee:

Barbara Ramiro

Reporter:

Barbara Ramiro

Integrator:

Dan Poltawski

Tester:

David Monllaó

Participants:

Barbara Ramiro, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Mary Evans, Michael de Raadt

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

30/Oct/12 4:33 PM

Updated:

10/Nov/12 1:11 AM

Resolved:

10/Nov/12 1:11 AM

Fix Release Date:

3/Dec/12