Moodle

Redesign activity icons in svg and png formats

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.2
  • Fix Version/s: 2.4
  • Component/s: Usability
  • Labels:
  • Testing Instructions:
    Hide

    Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange.

    Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons

    1. log on
    2. click "turn editing on"
    3. click "add an activity or resource"
    4. refer to the attached screenshot above to see what to expect for each icon visually
    5. zoom out (ctrl +) to the max the activity chooser window to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format in 72ppi
    6. check the course page as well if it is showing the icons properly
    Show
    Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange. Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons log on click "turn editing on" click "add an activity or resource" refer to the attached screenshot above to see what to expect for each icon visually zoom out (ctrl +) to the max the activity chooser window to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format in 72ppi check the course page as well if it is showing the icons properly
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-36277-master
  • Pull Master Diff URL:

Description

Redesign activity icons in svg and png formats

Issue Links

testing discovered

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36443 Consistency across icons when themes override some, but not all, standard icons

  • Minor - Minor loss of function where workaround is possible
  • Open - The issue is open and ready for the assignee to start work on it.

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36440 Padding between activites with new SVG & PNG icons

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36441 No gap between the edit section icon and the section activities in some themes

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36442 Blocks header color of Boxxie theme doesn't get along with new grey icons

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36446 Resources icon of block activities (f/html)

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36290 Outputlib post_process does not revert $usesvg

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Barbara Ramiro added a comment -

attached is the screenshot of the new set of activity icons

Show
Barbara Ramiro added a comment - attached is the screenshot of the new set of activity icons
Hide
Permalink
Michael de Raadt added a comment -

I just noted that the icon for Choice looks like a folder in your screen capture.

Show
Michael de Raadt added a comment - I just noted that the icon for Choice looks like a folder in your screen capture.
Hide
Permalink
Barbara Ramiro added a comment -

Thanks Michael. Here is a screenshot from the actual branch, replacing the previous screenshot to avoid confusion.

Show
Barbara Ramiro added a comment - Thanks Michael. Here is a screenshot from the actual branch, replacing the previous screenshot to avoid confusion.
Hide
Permalink
Dan Poltawski added a comment -

Thanks Barbara, thats been integrated now.

Show
Dan Poltawski added a comment - Thanks Barbara, thats been integrated now.
Hide
Permalink
Dan Poltawski added a comment -

I've spotted one problem during integration testing. The icon for a 'resource' when its off unknown type seems wrong.

I'm holding off creating an issue for this right now until this has had a testing iteration. See above screenshot.

Show
Dan Poltawski added a comment - I've spotted one problem during integration testing. The icon for a 'resource' when its off unknown type seems wrong. I'm holding off creating an issue for this right now until this has had a testing iteration. See above screenshot.
Hide
Permalink
David Monllaó added a comment -

Hi Andrew,

I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.

Show
David Monllaó added a comment - Hi Andrew, I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.
Hide
Permalink
David Monllaó added a comment - - edited

Tested in:

  • Android 4.x (Chrome, Firefox and built-in browser)
  • Android 2.3 (Firefox and built-in browser)
  • iPhone (Safari)
  • iPad (Safari)
  • Linux (Firefox and Chrome)
  • Windows (IE9 and Firefox)

Things to report:

  • MDL-36290 problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg
  • 'navigationitem' image of the navigation block (visible for example inside 'Question bank' items) is still a pixel image (http://tracker.moodle.org/browse/MDL-36398)
  • Big activity icons in navigation block (http://tracker.moodle.org/browse/MDL-36323)
  • Resources icon in activities block (http://tracker.moodle.org/browse/MDL-36446)
  • Some themes overrides the standard themes icons, there is a mix of icon formats
  • There is no gap between the edit section icon and the section activities in the following themes: arialist, anomaly, binarius, boxxie, canvas, formfactor, leatherbound, magazine, nimble, nonzero, serenity, sky_high and splash (anomaly image attached)
  • There is a little overlapping between activity icons in sections in the following themes: fusion and anomaly (anomaly image attached)
  • In boxxie theme, the block editing icons are a bit dark for that dark green
Show
David Monllaó added a comment - - edited Tested in: Android 4.x (Chrome, Firefox and built-in browser) Android 2.3 (Firefox and built-in browser) iPhone (Safari) iPad (Safari) Linux (Firefox and Chrome) Windows (IE9 and Firefox) Things to report: MDL-36290 problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg 'navigationitem' image of the navigation block (visible for example inside 'Question bank' items) is still a pixel image ( http://tracker.moodle.org/browse/MDL-36398 ) Big activity icons in navigation block ( http://tracker.moodle.org/browse/MDL-36323 ) Resources icon in activities block ( http://tracker.moodle.org/browse/MDL-36446 ) Some themes overrides the standard themes icons, there is a mix of icon formats There is no gap between the edit section icon and the section activities in the following themes: arialist, anomaly, binarius, boxxie, canvas, formfactor, leatherbound, magazine, nimble, nonzero, serenity, sky_high and splash (anomaly image attached) There is a little overlapping between activity icons in sections in the following themes: fusion and anomaly (anomaly image attached) In boxxie theme, the block editing icons are a bit dark for that dark green
Hide
Permalink
David Monllaó added a comment -

After talking with Barbara and Dan we pass the issue and create new issues with the related problems. Linking remaining issues

Show
David Monllaó added a comment - After talking with Barbara and Dan we pass the issue and create new issues with the related problems. Linking remaining issues
Hide
Permalink
Mary Evans added a comment -

I'm trying to fix the themes but after updating Moodle I still don't see the new icons. Am I missing something here?

Show
Mary Evans added a comment - I'm trying to fix the themes but after updating Moodle I still don't see the new icons. Am I missing something here?
Hide
Permalink
Mary Evans added a comment -

Sorry...my brain must be in nuetral...disregard my last comment, I've just realised my mistake.

Show
Mary Evans added a comment - Sorry...my brain must be in nuetral...disregard my last comment, I've just realised my mistake.
Hide
Permalink
Dan Poltawski added a comment -

Hi Mary, just making sure you're seening the work going on in the subtasks too.

Show
Dan Poltawski added a comment - Hi Mary, just making sure you're seening the work going on in the subtasks too.
Hide
Permalink
Mary Evans added a comment -

When I get to commit these which version of Moodle should I be using? Currently it's 2012110101.00 which was last time I updated.

Also are these ALL the new icons on the QA site? Will make it easier to see the problems as a whole if they are.

Show
Mary Evans added a comment - When I get to commit these which version of Moodle should I be using? Currently it's 2012110101.00 which was last time I updated. Also are these ALL the new icons on the QA site? Will make it easier to see the problems as a whole if they are.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

(not really)

Closing, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: