Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36316

Eliminate user-agent sniffing where possible

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.6
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Exploritory test Moodle in IE
      2. Try downloading files in IE and firefox
      3. Enable the gradebook fixed students report and test it in all browsers
      4. Enable and try tinymce on all browsers.

      (Note that bugs from use of these will probably not be frm this issue, so we will need to compare against before the patch)

      Show
      Exploritory test Moodle in IE Try downloading files in IE and firefox Enable the gradebook fixed students report and test it in all browsers Enable and try tinymce on all browsers. (Note that bugs from use of these will probably not be frm this issue, so we will need to compare against before the patch)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-36316-master

      Description

      Its generally regarded as bad practice to do user-agent sniffing to control features. Problems with ua-sniffing were aptly demonstrated in MDL-35469, where features stopped working in latest version of firefox due to bad ua-sniffing.

      Most of the UA sniffing across moodle seems to be detecting really old browsers which are unsupported by Moodle, these could be eliminated.

      For JS, we should be doing feature detection (see http://modernizr.com/ etc).

      There will be some exceptions which we can't get rid of, but there is a lot of legacy rubbish we should be tidying up.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                poltawski Dan Poltawski
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Frédéric Massart
                Integrator:
                Sam Hemelryk
                Tester:
                Mark Nelson
                Participants:
                Component watchers:
                Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                3 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13