Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36321

Can't remove contacts from a course group in messaging.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      To test this you'll need at least 2 users and a course with those users enrolled in it.

      1) Log in as a user and go to your messages.
      2) Remove any contacts your user might have.
      3) Select your course from the messaging navigation drop down.
      4) Click the plus sign to add a course participant as a contact. You will be redirected to your contact list.

      5) Go back to the course participants page and click the cross to remove the participant as a contact. This will bring you back to the participants page.
      6) Similarly, block and then unblock a user.
      7) Click the message history icon next to a course participant and check that the relevant message history is displayed.

      Show
      To test this you'll need at least 2 users and a course with those users enrolled in it. 1) Log in as a user and go to your messages. 2) Remove any contacts your user might have. 3) Select your course from the messaging navigation drop down. 4) Click the plus sign to add a course participant as a contact. You will be redirected to your contact list. 5) Go back to the course participants page and click the cross to remove the participant as a contact. This will bring you back to the participants page. 6) Similarly, block and then unblock a user. 7) Click the message history icon next to a course participant and check that the relevant message history is displayed.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36321_message_participants

      Description

      1. Visit a course.
      2. Create a group and add multiple users, including the administrator account.
      3. Go to your messages via <yoursiteurl>/message/index.php
      4. In the drop down select the course where you just created the group in step 2 and added yourself.
      5. Attempt to remove a user and see that you can not.

      Should the user be able to remove a user from a group for their course or do we just remove the icon?

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              andyjdavis Andrew Davis added a comment - - edited

              The icons are being displayed incorrectly. You should be able to add the user as a contact from the list of participants. For some reason the "remove contact" icon is being displayed even though course participants are not contacts.

              Show
              andyjdavis Andrew Davis added a comment - - edited The icons are being displayed incorrectly. You should be able to add the user as a contact from the list of participants. For some reason the "remove contact" icon is being displayed even though course participants are not contacts.
              Hide
              andyjdavis Andrew Davis added a comment -

              Here is a potential solution. While I was there I removed some code that was setting config settings that were never used. They seem to have been left over from 1.9.

              Show
              andyjdavis Andrew Davis added a comment - Here is a potential solution. While I was there I removed some code that was setting config settings that were never used. They seem to have been left over from 1.9.
              Hide
              phalacee Jason Fowler added a comment -

              [y] Syntax
              [-] Output
              [y] Whitespace
              [-] Language
              [-] Databases
              [y] Testing
              [-] Security
              [-] Documentation
              [y] Git
              [y] Sanity check

              Great Andrew

              Show
              phalacee Jason Fowler added a comment - [y] Syntax [-] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check Great Andrew
              Hide
              andyjdavis Andrew Davis added a comment -

              Added 2.4 and 2.3 versions. Submitting for integration.

              Show
              andyjdavis Andrew Davis added a comment - Added 2.4 and 2.3 versions. Submitting for integration.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Andrew, has been integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Andrew, has been integrated now.
              Hide
              dmonllao David Monllaó added a comment -

              Logged as a student without contacts, when I select a course from the message navigation drop down menu I see the list of participants with 'Remove contact' icon instead of the add contact icon, if I click on it nothing happens. I've experienced the same problem in 22 and master

              Show
              dmonllao David Monllaó added a comment - Logged as a student without contacts, when I select a course from the message navigation drop down menu I see the list of participants with 'Remove contact' icon instead of the add contact icon, if I click on it nothing happens. I've experienced the same problem in 22 and master
              Hide
              poltawski Dan Poltawski added a comment -

              Ping, Andrew?

              Show
              poltawski Dan Poltawski added a comment - Ping, Andrew?
              Hide
              andyjdavis Andrew Davis added a comment -

              Looking at this now.

              Show
              andyjdavis Andrew Davis added a comment - Looking at this now.
              Hide
              dmonllao David Monllaó added a comment -

              I've retested it without being able to reproduce the problem I reported, grepping MOODLE_22_STABLE log I see it was not integrated there and the only explication I have about the fail in master is that I pick the stable site instead of integration, sorry about the confusion. The problem still exists in 22. Dan please, can you reset the status of the issue? TIA

              Show
              dmonllao David Monllaó added a comment - I've retested it without being able to reproduce the problem I reported, grepping MOODLE_22_STABLE log I see it was not integrated there and the only explication I have about the fail in master is that I pick the stable site instead of integration, sorry about the confusion. The problem still exists in 22. Dan please, can you reset the status of the issue? TIA
              Hide
              poltawski Dan Poltawski added a comment -

              Done.

              Show
              poltawski Dan Poltawski added a comment - Done.
              Hide
              andyjdavis Andrew Davis added a comment -

              I mistakenly believed that the HQ support period for 2.2 had ended. It actually has another month to go. I have added a 2.2 version. https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-36321_message_participants_22

              Show
              andyjdavis Andrew Davis added a comment - I mistakenly believed that the HQ support period for 2.2 had ended. It actually has another month to go. I have added a 2.2 version. https://github.com/andyjdavis/moodle/compare/MOODLE_22_STABLE...MDL-36321_message_participants_22
              Hide
              dmonllao David Monllaó added a comment -

              Thanks Andrew, I wait for the 2.2 patch integrated to test it again

              Show
              dmonllao David Monllaó added a comment - Thanks Andrew, I wait for the 2.2 patch integrated to test it again
              Hide
              dmonllao David Monllaó added a comment -

              It works perfectly. Tested in 22, 23 and master

              Show
              dmonllao David Monllaó added a comment - It works perfectly. Tested in 22, 23 and master
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Jan/13