Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36324

Missing string deletestorehasmappings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to Settings > Plugins > Caching > Configuration
      3. Add an instance of the file store give it the name test.
      4. Map the Language string cache to use it.
      5. Try to delete the store, confirm you see the correct string.
      Show
      Log in as an admin Browse to Settings > Plugins > Caching > Configuration Add an instance of the file store give it the name test. Map the Language string cache to use it. Try to delete the store, confirm you see the correct string.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36324-m24

      Description

      Deleting a cache store with mappings leads to:

      Invalid get_string() identifier: 'deletestorehasmappings' or component 'moodle'. Perhaps you are missing $string['deletestorehasmappings'] = ''; in lang/en/moodle.php?
      line 6738 of /lib/moodlelib.php: call to debugging()
      line 7405 of /lib/moodlelib.php: call to core_string_manager->get_string()
      line 106 of /cache/admin.php: call to get_string()

        Gliffy Diagrams

          Activity

          Hide
          samhemelryk Sam Hemelryk added a comment -

          Putting this straight up for integration. Thanks for the report Dan, I had missed the cache component on the get_string call.

          Show
          samhemelryk Sam Hemelryk added a comment - Putting this straight up for integration. Thanks for the report Dan, I had missed the cache component on the get_string call.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Sam, i've integrated this now.

          Show
          poltawski Dan Poltawski added a comment - Thanks Sam, i've integrated this now.
          Hide
          markn Mark Nelson added a comment -

          Received the error "You cannot delete this store because it has mappings. Please delete all mappings before deleting the store". Looks good to me. Passing.

          Show
          markn Mark Nelson added a comment - Received the error "You cannot delete this store because it has mappings. Please delete all mappings before deleting the store". Looks good to me. Passing.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12