Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36327

moodle-core-notification lacks accessibility on close button

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Alas, not many places currently use moodle-core-notification (this will be changed in time) so you'll have to do some fudging I'm afraid.

      • edit /enrol/manual/ajax.php
      • add a die(); line somewhere early on
      • open a course, and browse to the list of enrolled users
      • click the 'Enrol users' button
      • A Syntax Error box should appear
      • Confirm that the 'X' is highlighted
      • Inspect the X and confirm that it is an anchor
      • click the X with the mouse
      • Confirm that the syntax error warning was closed
      • Refresh and re-open the 'Enrol users' box
      • Ensure that the X is highlighted, and press the Return key on the keyboard
      • Confirm that the syntax error warning was closed

      Alternatively, check out the new popup help (MDL-35819) and open a help box and confirm that it works as expected there instead

      Show
      Alas, not many places currently use moodle-core-notification (this will be changed in time) so you'll have to do some fudging I'm afraid. edit /enrol/manual/ajax.php add a die(); line somewhere early on open a course, and browse to the list of enrolled users click the 'Enrol users' button A Syntax Error box should appear Confirm that the 'X' is highlighted Inspect the X and confirm that it is an anchor click the X with the mouse Confirm that the syntax error warning was closed Refresh and re-open the 'Enrol users' box Ensure that the X is highlighted, and press the Return key on the keyboard Confirm that the syntax error warning was closed Alternatively, check out the new popup help ( MDL-35819 ) and open a help box and confirm that it works as expected there instead
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-36327-master

      Description

      Just noticed that moodle-core-notification has no alt or title text on it's close button. It's also not possible to tab to the button to close the dialogue in that manner.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: