Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36334

Add support for selected gallery modules

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Set $CFG->useexternalyui = 1;
      • Open the Moodle frontpage
      • Open browser dev tools and the Network console
      • Clear the network console of any initial activity
      • In the console run:

        YUI().use('gallery-sm-treeview');
        

        • confirm no errors were shown in the console
        • confirm that the network tab showed a number of JS scripts were loaded (there's also some CSS)
        • confirm that the scripts have appropriate content
        • confirm that the gallery scripts were loaded from your local server and not the CDN (some non-gallery dependencies will be loaded from the CDN because of the useexternalyui setting)

      To test we didn't break the SCORM module:

      • Create a new SCORM module in your course (use test file /mod/scorm/tests/packages/singlescobasic.zip if you need one)
      • Make sure the setting "Display course structure in player" is set to "to the side" (this is the default)
      • Enter the SCORM as a student and make sure no new JS errors occur that weren't there before.
      Show
      Set $CFG->useexternalyui = 1; Open the Moodle frontpage Open browser dev tools and the Network console Clear the network console of any initial activity In the console run: YUI().use('gallery-sm-treeview'); confirm no errors were shown in the console confirm that the network tab showed a number of JS scripts were loaded (there's also some CSS) confirm that the scripts have appropriate content confirm that the gallery scripts were loaded from your local server and not the CDN (some non-gallery dependencies will be loaded from the CDN because of the useexternalyui setting) To test we didn't break the SCORM module: Create a new SCORM module in your course (use test file /mod/scorm/tests/packages/singlescobasic.zip if you need one) Make sure the setting "Display course structure in player" is set to "to the side" (this is the default) Enter the SCORM as a student and make sure no new JS errors occur that weren't there before.
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-36334-master
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 7

      Description

      We need to look at the best way of doing this. From a quick play:

      • lib/outputrequirements.php::__construct() needs to remove the gallery group if we're using the CDN
      • lib/outputrequirements.php::__construct() needs to have the correct base for lib/yuilib/gallery/
      • we need to include a specific snapshot of gallery in lib/yuilib/gallery - preferably the same version as defined in lib/yuilib/3.7.3/build/loader/loader.js
      • we need to drop $galleryversion from yui_module() and force people to use the gallery version that we ship which will be the same version as the loader defines

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Petr Skoda
              Integrator:
              Sam Hemelryk
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14