Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange.

      Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons

      The aim of this test is to check how the activity actions icons are displayed

      1. Go to a course with users and groups
      2. Enable editing mode
      3. Create an activity on it (is not important which one, is only to check the icons)
      4. Check how the icons are displayed. Refer to the attached screenshot above to see what to expect for each icon visually
      5. Try actions like hide/show or change the group visibility of the activity to see icons not displayed initially
      6. Disable javascript to check the non-JS icons like 'move'
      7. Zoom out (ctrl +) to the max on the course page and block header to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format
      Show
      Is important to test this issue in different browsers including (IE 8 and 10, Firefox and Chrome) in different OS (Windows, iOS and Linux) In browsers that supports SVG you can also try to zoom in and zoom out to check there is nothing strange. Browsers that does not supports SVG SHOULD display the .png icons, browsers that supports SVG SHOULD display the SVG icons The aim of this test is to check how the activity actions icons are displayed Go to a course with users and groups Enable editing mode Create an activity on it (is not important which one, is only to check the icons) Check how the icons are displayed. Refer to the attached screenshot above to see what to expect for each icon visually Try actions like hide/show or change the group visibility of the activity to see icons not displayed initially Disable javascript to check the non-JS icons like 'move' Zoom out (ctrl +) to the max on the course page and block header to see each svg icon scale up without pixelation except on ie8 and higher because it is showing the fallback png format
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36338-master
    • Rank:
      45132

      Description

      Redesign edit icons in svg and png formats

      1. ie9sg2.png
        11 kB
      2. ie9svg.png
        7 kB
      3. new-edit-icons.png
        11 kB

        Issue Links

          Activity

          Hide
          Barbara Ramiro added a comment -

          attached is the screenshot of the new edit icons

          Show
          Barbara Ramiro added a comment - attached is the screenshot of the new edit icons
          Hide
          Dan Poltawski added a comment -

          Bringing straight into integration since no peer reviewers came forward.

          Show
          Dan Poltawski added a comment - Bringing straight into integration since no peer reviewers came forward.
          Hide
          Dan Poltawski added a comment -

          Thanks Barbara, i've integrated this now!

          David, as discussed, hoping you can flesh out the testing instructions a bit.

          Show
          Dan Poltawski added a comment - Thanks Barbara, i've integrated this now! David, as discussed, hoping you can flesh out the testing instructions a bit.
          Hide
          David Monllaó added a comment -

          Hi Fred,

          I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.

          Show
          David Monllaó added a comment - Hi Fred, I'll be testing the issue in Android (2.3.x and 4.x) and i(Phone|Pad) devices.
          Hide
          Frédéric Massart added a comment -

          Sorry, I have to fail this.

          Tested on:

          • Chromium, Ubuntu
          • Opera, Ubuntu
          • Firefox, Ubuntu
          • IE8, Windows 7
          • IE9, Windows 7
          • Android 4.0

          On Opera the zoom does not work properly, and I know we are not supporting it so I did not set it as a 'failure', also I don't think it is Moodle's fault.

          On IE9, the SVG instead of PNG as it is supposed to, but they are cropped for some reason. I don't know what part of the CSS plays a role in that. See the attached screenshots.

          Show
          Frédéric Massart added a comment - Sorry, I have to fail this. Tested on: Chromium, Ubuntu Opera, Ubuntu Firefox, Ubuntu IE8, Windows 7 IE9, Windows 7 Android 4.0 On Opera the zoom does not work properly, and I know we are not supporting it so I did not set it as a 'failure', also I don't think it is Moodle's fault. On IE9, the SVG instead of PNG as it is supposed to, but they are cropped for some reason. I don't know what part of the CSS plays a role in that. See the attached screenshots.
          Hide
          David Monllaó added a comment -

          Tested in:
          Android 4.x (Chrome, Firefox and built-in browser)
          Android 2.3 (Firefox and built-in browser)
          iPhone (Safari)
          iPad (Safari)

          Using the default standard theme and mymobile theme, only MDL-36290 problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg

          Show
          David Monllaó added a comment - Tested in: Android 4.x (Chrome, Firefox and built-in browser) Android 2.3 (Firefox and built-in browser) iPhone (Safari) iPad (Safari) Using the default standard theme and mymobile theme, only MDL-36290 problem detected on non-block contents, displaying .png instead of .svg in browsers that supports .svg
          Hide
          Frédéric Massart added a comment -

          Raised MDL-36449 to fix the IE issue

          Show
          Frédéric Massart added a comment - Raised MDL-36449 to fix the IE issue
          Hide
          Dan Poltawski added a comment -

          Passed as new issues created

          Show
          Dan Poltawski added a comment - Passed as new issues created
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: