Moodle
  1. Moodle
  2. MDL-36360

Missing of cachestore_file::config_get_configuration_array()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:

      Description

      On adding a new file cache store instance, cache_administration_helper::get_store_configuration_from_data is unable to do correctly its job preventing the correct configuration of the provided custom params set for the new file based cache store.

        Gliffy Diagrams

          Activity

          Hide
          Matteo Scaramuccia added a comment -

          I've removed the 'lock' definition being not part of the form definition: if correct, feel free of squashing the 2 commits into one.

          Show
          Matteo Scaramuccia added a comment - I've removed the 'lock' definition being not part of the form definition: if correct, feel free of squashing the 2 commits into one.
          Hide
          Sam Hemelryk added a comment -

          Thanks again Matteo for both reporting and fixing the issue Its a massive help!

          I've increased this issue to a blocker, it needs to land before the release of 2.4.
          I'll also push this up for integration now, I've looked at the code and its spot on.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Thanks again Matteo for both reporting and fixing the issue Its a massive help! I've increased this issue to a blocker, it needs to land before the release of 2.4. I'll also push this up for integration now, I've looked at the code and its spot on. Many thanks Sam
          Hide
          Matteo Scaramuccia added a comment -

          FYI (even if I'm pretty sure you already know it ): when MDL-36120 will land, an update to cachestore_file: :config_get_configuration_array() must be done to include the new singledirectory field i.e. MDL-36120 pull must be updated if MDL-36360 will land first => kind of intelligent rebase (rebase + improvement).

          Show
          Matteo Scaramuccia added a comment - FYI (even if I'm pretty sure you already know it ): when MDL-36120 will land, an update to cachestore_file: :config_get_configuration_array() must be done to include the new singledirectory field i.e. MDL-36120 pull must be updated if MDL-36360 will land first => kind of intelligent rebase (rebase + improvement).
          Hide
          Dan Poltawski added a comment -

          Thanks Matteo & Sam, i've integrated this now

          Show
          Dan Poltawski added a comment - Thanks Matteo & Sam, i've integrated this now
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: