Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 2.4
-
Fix Version/s: 2.4
-
Component/s: Caching
-
Labels:
-
Testing Instructions:
- Log in as an admin
- Browse to Admin > Plugins > Caching > Configuration
- Add an instance of the file store.
- Check you don't get errors and that the file store instance is created successfully.
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:m24_
MDL-36360_Missing_cachestore_file_config_get_configuration_array
Description
On adding a new file cache store instance, cache_administration_helper::get_store_configuration_from_data is unable to do correctly its job preventing the correct configuration of the provided custom params set for the new file based cache store.
Gliffy Diagrams
Activity
Thanks again Matteo for both reporting and fixing the issue 
Its a massive help!
I've increased this issue to a blocker, it needs to land before the release of 2.4.
I'll also push this up for integration now, I've looked at the code and its spot on.
Many thanks
Sam
FYI (even if I'm pretty sure you already know it 
): when MDL-36120 will land, an update to cachestore_file: :config_get_configuration_array() must be done to include the new singledirectory field i.e. MDL-36120 pull must be updated if MDL-36360 will land first => kind of intelligent rebase (rebase + improvement).
Thanks Matteo & Sam, i've integrated this now
Works as described. Passing.
Amazed. Inspired. Grateful. That’s how your generosity makes me feel.
(not really)
Closing, thanks!
I've removed the 'lock' definition being not part of the form definition: if correct, feel free of squashing the 2 commits into one.