Moodle
  1. Moodle
  2. MDL-36364

cachestore_file::delete() always removes the key

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Rank:
      45173

      Description

      cachestore_file ::delete() always removes the key regardless the deletion of the file caching the value pointed by that key has been successful.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Thanks Matteo,

        Thanks again for creating the report and for providing the patch!

        The patch itself looks 100% perfect!
        I've made you the assignee and have put this up for integration now in the hope it will still have a chance of getting in before the release of 2.4.

        Integrations: This is 100% safe.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Matteo, Thanks again for creating the report and for providing the patch! The patch itself looks 100% perfect! I've made you the assignee and have put this up for integration now in the hope it will still have a chance of getting in before the release of 2.4. Integrations: This is 100% safe. Many thanks Sam
        Hide
        Dan Poltawski added a comment -

        Thanks guys, i've integrated this now.

        There was a very close conflict, but I think i've resolved that properly. If you can check over the code it'd give me extra piece of mind

        Show
        Dan Poltawski added a comment - Thanks guys, i've integrated this now. There was a very close conflict, but I think i've resolved that properly. If you can check over the code it'd give me extra piece of mind
        Hide
        Dan Poltawski added a comment -

        Looking good

        Show
        Dan Poltawski added a comment - Looking good
        Hide
        Matteo Scaramuccia added a comment -

        Hi Dan,
        indeed http://git.moodle.org/gw?p=integration.git;a=commitdiff;h=bc8f1957a433e505539d0b60e3ed6c4e8da236b1 looks good (sorry, missing rebasing here) including:

        $ git show bc8f195
        ...
        @@@ -682,4 -571,4 +686,4 @@@
              public function my_name() {
                  return $this->name;
              }
        --}
        ++}
        
        Show
        Matteo Scaramuccia added a comment - Hi Dan, indeed http://git.moodle.org/gw?p=integration.git;a=commitdiff;h=bc8f1957a433e505539d0b60e3ed6c4e8da236b1 looks good (sorry, missing rebasing here) including: $ git show bc8f195 ... @@@ -682,4 -571,4 +686,4 @@@ public function my_name() { return $this->name; } --} ++}
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many, many thanks for your effort!

        Millions of people will enjoy the results of your work, yay!

        Closing as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao
        Hide
        Sam Hemelryk added a comment -

        Yip looks good thanks Dan

        Show
        Sam Hemelryk added a comment - Yip looks good thanks Dan

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: