Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36367

Calendar "month" view - HTML classes are inconsistent (Backport MDL-31824)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Visit moodle/calendar/view.php?view=month.

      • Check the classes applied to days in the the current month and days in any other month.
      • On the current month all days have the class "nottoday" (except the actual current day)
      • The current day should have the class "today"
      • Apply a few of the main themes, and check the calendar to ensure it isn't broken.
      Show
      Visit moodle/calendar/view.php?view=month. Check the classes applied to days in the the current month and days in any other month. On the current month all days have the class "nottoday" (except the actual current day) The current day should have the class "today" Apply a few of the main themes, and check the calendar to ensure it isn't broken.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:

      Description

      Back port logic change for MDL-31824 to stable branches

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            Hard to argue with something thats already been integrated. Just make sure to copy the testing instructions from the original issue.

            Show
            andyjdavis Andrew Davis added a comment - Hard to argue with something thats already been integrated. Just make sure to copy the testing instructions from the original issue.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Jason,

            On the original issue there was discussion of this not being backported due to the concern about breaking themes.

            Could you explain has this considered on this issue?

            Show
            poltawski Dan Poltawski added a comment - Hi Jason, On the original issue there was discussion of this not being backported due to the concern about breaking themes. Could you explain has this considered on this issue?
            Hide
            phalacee Jason Fowler added a comment -

            The theme issues were mainly about the route I initially wanted to take. Didn't end up taking that route, and seeing as the test instructions on the older issue passed (they included instructions to test in other themes) I would assume that the themes would work with this too. Will test it out when i get in to work in the morning though.

            Show
            phalacee Jason Fowler added a comment - The theme issues were mainly about the route I initially wanted to take. Didn't end up taking that route, and seeing as the test instructions on the older issue passed (they included instructions to test in other themes) I would assume that the themes would work with this too. Will test it out when i get in to work in the morning though.
            Hide
            poltawski Dan Poltawski added a comment -

            I couldn't find the 2.2 branch, but I cherry-picked it myself.

            Show
            poltawski Dan Poltawski added a comment - I couldn't find the 2.2 branch, but I cherry-picked it myself.
            Hide
            dmonllao David Monllaó added a comment -

            Tested with IE10 using standard, fusion and afterburner, the correct nottoday and today classes are applied but the current day is only shown in the standard theme, as talked with Jason further work to make all the themes highlight today is done in another issue

            Show
            dmonllao David Monllaó added a comment - Tested with IE10 using standard, fusion and afterburner, the correct nottoday and today classes are applied but the current day is only shown in the standard theme, as talked with Jason further work to make all the themes highlight today is done in another issue
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And your fantastic code has met core, hope they become good friends for a long period.

            Closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13