Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      1. Log on
      2. Turn editing on
      3. Dock any block and make sure that (1)the close icon and (2)the dock to block icon are displaying the new svg/png icons (refer to docked-icons.png for the expected outcome)
      4. Hide and show any block and make sure that (1)the hide icon and (2) the show icon are displaying the new svg/png icons (refer to show-block-icons.png)
      5. Show the Navigation block and make sure that all posible levels are showing all the new svg/png icons as shown on navigation-block-icons.png (10 new icons are expected)
      6. Please test all the icons in ie8 and higher and make sure that all new png icons are shown as expected based on the screenshots mentioned.

      Note: If there is any icon i missed please file an issue right away rather than failing this. Also the sizes might not be correct as Fred will be working on the CSS later on. Please coordinate with me or Fred.

      Show
      1. Log on 2. Turn editing on 3. Dock any block and make sure that (1)the close icon and (2)the dock to block icon are displaying the new svg/png icons (refer to docked-icons.png for the expected outcome) 4. Hide and show any block and make sure that (1)the hide icon and (2) the show icon are displaying the new svg/png icons (refer to show-block-icons.png) 5. Show the Navigation block and make sure that all posible levels are showing all the new svg/png icons as shown on navigation-block-icons.png (10 new icons are expected) 6. Please test all the icons in ie8 and higher and make sure that all new png icons are shown as expected based on the screenshots mentioned. Note: If there is any icon i missed please file an issue right away rather than failing this. Also the sizes might not be correct as Fred will be working on the CSS later on. Please coordinate with me or Fred.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36398-master
    • Rank:
      45216

      Description

      Redesign navigation block icons in svg and png formats

      1. docked-icons.png
        58 kB
      2. navigation-block-icons.png
        100 kB
      3. show-block-icon.png
        8 kB

        Issue Links

          Activity

          Hide
          Barbara Ramiro added a comment -

          Attached screenshots for the expected icon changes. You will notice that the icons are smaller than 12px but Fred is working on the CSS part including paddings.

          Show
          Barbara Ramiro added a comment - Attached screenshots for the expected icon changes. You will notice that the icons are smaller than 12px but Fred is working on the CSS part including paddings.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Barbara

          Show
          Dan Poltawski added a comment - Integrated, thanks Barbara
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Barbara,

          In RTL languages, block gets docked on right side. So I think it will be nice to have appropriate image for RTL (Arrow pointing right when not docked and arrow pointing left when docked)

          Let me know if you want me to open another issue or it's been taken care by existing issue.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Barbara, In RTL languages, block gets docked on right side. So I think it will be nice to have appropriate image for RTL (Arrow pointing right when not docked and arrow pointing left when docked) Let me know if you want me to open another issue or it's been taken care by existing issue.
          Hide
          Barbara Ramiro added a comment -

          Thanks Raj for pointing out this matter. I know Fred worked on it but not sure if the rtl arrows i committed were used. Better open another issue and assign it to Fred. Cheers

          Show
          Barbara Ramiro added a comment - Thanks Raj for pointing out this matter. I know Fred worked on it but not sure if the rtl arrows i committed were used. Better open another issue and assign it to Fred. Cheers
          Hide
          Rajesh Taneja added a comment -

          Thanks Barbara,

          I have create MDL-36613 as sub-task of main issue as discussed with Fred. Thanks for the great icons though, they look great

          Show
          Rajesh Taneja added a comment - Thanks Barbara, I have create MDL-36613 as sub-task of main issue as discussed with Fred. Thanks for the great icons though, they look great
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many, many thanks for your effort!

          Millions of people will enjoy the results of your work, yay!

          Closing as fixed. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: