Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Goto calendar>manager subscription
      2. Fill the form, choose ics file option from the drop down
      3. Try to drag and drop a file to the file picker area which is not .ics, make sure you get an error
      4. Try with a correct .ics file and make sure its saved and imported as expected
        A sample ics file :- http://tracker.moodle.org/secure/attachment/30056/AustraliaHolidays.ics
      Show
      Goto calendar>manager subscription Fill the form, choose ics file option from the drop down Try to drag and drop a file to the file picker area which is not .ics, make sure you get an error Try with a correct .ics file and make sure its saved and imported as expected A sample ics file :- http://tracker.moodle.org/secure/attachment/30056/AustraliaHolidays.ics
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36400-master

      Description

      If a non .ics file is selected as a calendar for import, it is accepted and the calendar listed under subscriptions.

      Non .ics files should not be accepted. A message should be displayed informing users of the invalid file.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              ankit_frenz Ankit Agarwal added a comment -

              I have committed this on top of integration to reduce conflicts.
              Requesting a review.

              Show
              ankit_frenz Ankit Agarwal added a comment - I have committed this on top of integration to reduce conflicts. Requesting a review.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Hi Ankit,

              The patch looks good.

              [y] Syntax
              [y] Output
              [y] Whitespace
              [-] Language
              [-] Databases
              [y] Testing
              [-] Security
              [-] Documentation
              [y] Git
              [y] Sanity check

              Show
              rwijaya Rossiani Wijaya added a comment - Hi Ankit, The patch looks good. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Integration time!
              Thanks for the review Rosie.

              Show
              ankit_frenz Ankit Agarwal added a comment - Integration time! Thanks for the review Rosie.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Ankit, this has been integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Ankit, this has been integrated now.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Marking this as passed, it will be tested by MDLQA-5221.

              Show
              samhemelryk Sam Hemelryk added a comment - Marking this as passed, it will be tested by MDLQA-5221 .
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Y E S !

              Closing as fixed, many thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12