Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36407

Horrible performance if langstringcache is off

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Run unit tests
      2. Log in as an admin
      3. Turn off langstringcache (use the settings search)
      4. Check that your load times for the front page are about normal (not 8s)
      5. Turn on langstringcache
      6. Check that your load times for the back page are about normal (not 8s)
      Show
      Run unit tests Log in as an admin Turn off langstringcache (use the settings search) Check that your load times for the front page are about normal (not 8s) Turn on langstringcache Check that your load times for the back page are about normal (not 8s)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36407-m24

      Description

      After MDL-34342 and MDL-36362 were integrated we found those with $CFG->langstringcache off we getting horrible performance.
      This was coming about because the lang string cache uses an ad-hoc cache when that is off and it doesn't know the data is simple.
      As such it inspects the component packs to find out whether it needs to unref things.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12