Moodle
  1. Moodle
  2. MDL-34080 Complete overhaul of all standard icons in core
  3. MDL-36415

Ordering arrow bigger than expected

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3.3
        • Fix Version/s: 2.4
        • Component/s: Usability
        • Labels:
          None
        • Testing Instructions:
          Hide
          1. Navigate to places where:
            • Elements can be moved up and down (sometimes only available when JS is off, IE: section moving)
            • Elements can be sorted in a table (users list, ...)
          2. Make sure
            • the new icon are used
            • they look good (margin, padding, vertical-align)
            • they make sense

          FYI: Few places to look:

          1. Question bank
          2. admin pages with tables (Browse users)
          3. Course enrolment page
          4. Course edit page without ajax or JS.
          Show
          Navigate to places where: Elements can be moved up and down (sometimes only available when JS is off, IE: section moving) Elements can be sorted in a table (users list, ...) Make sure the new icon are used they look good (margin, padding, vertical-align) they make sense FYI: Few places to look: Question bank admin pages with tables (Browse users) Course enrolment page Course edit page without ajax or JS.
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-36415-master-int
        • Pull Master Diff URL:

          Description

          • Go to a course enrolment page
          • The arrow to order users by last name ascending/descending is larger than before, probably too large

          See attached screenshots

            Gliffy Diagrams

            1. arrowafter.png
              4 kB
            2. arrowbefore.png
              5 kB
            3. Edit questions_up arrow.png
              9 kB

              Issue Links

              blocks

              Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36633 Administration icon issues

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Frédéric Massart added a comment -

                This might need a fix in the code as well to point to another icon in such case.

                Show
                Frédéric Massart added a comment - This might need a fix in the code as well to point to another icon in such case.
                Hide
                Permalink
                Barbara Ramiro added a comment -

                Assigning this to you Fred

                Show
                Barbara Ramiro added a comment - Assigning this to you Fred
                Hide
                Permalink
                Frédéric Massart added a comment -

                Yay! \o/

                Show
                Frédéric Massart added a comment - Yay! \o/
                Hide
                Permalink
                Rajesh Taneja added a comment -

                Thanks Fred,

                Patch looks Great, although as discussed up arrow is not aligned well.

                Adding a screen-shot for reference.

                Show
                Rajesh Taneja added a comment - Thanks Fred, Patch looks Great, although as discussed up arrow is not aligned well. Adding a screen-shot for reference.
                Hide
                Permalink
                Frédéric Massart added a comment -

                Thanks Raj, the look and feel was not as great as it could have been. I have created a new selector specific for this kind of icon, and add some rules to it. It now looks better. I also forgot about the upgrade.txt file which I have updated now. Pushing for integration.

                Cheers!

                Show
                Frédéric Massart added a comment - Thanks Raj, the look and feel was not as great as it could have been. I have created a new selector specific for this kind of icon, and add some rules to it. It now looks better. I also forgot about the upgrade.txt file which I have updated now. Pushing for integration. Cheers!
                Hide
                Permalink
                Dan Poltawski added a comment -

                Integrated, thanks

                Show
                Dan Poltawski added a comment - Integrated, thanks
                Hide
                Permalink
                Mark Nelson added a comment -

                Now that's some shmexy looking icons there if I do say so myself. Passing this, thanks Fredos.

                Show
                Mark Nelson added a comment - Now that's some shmexy looking icons there if I do say so myself. Passing this, thanks Fredos.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

                ciao
                Dan

                Show
                Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: