Before MDL-35339:
https://github.com/moodle/moodle/blob/4ede27b253ca58f08d1b6f0c8823c76ad38d433a/course/lib.php#L2820

After MDL-35339:
https://github.com/moodle/moodle/blob/38b19bbca12d06b5072618bb0b8b016ea2a40c53/course/lib.php#L2832

The call to update the visibility was skipped.

Pushing for peer review.

Following the chat I had with Petr about that, it appeared that it would much better to remove the logic generated by $prevstateoverrides and place it in the only place it was used, in set_section_visible().

Also, I am not entirely convinced about removing the argument entirely but Petr +10'd it, so there it is. I guess in the future we would classify the whole thing instead of adding more parameters to this function.

I thought of not updating the module's visibility if it was already set to whatever we were going to set, but I guess that's better to keep the current logic and reprocess what's in set_coursemodule_visible().

All yours! Thanks.

I like this because the section hiding/showing logic is now easier to understand. It should also eliminate problems with race conditions if you had multiple windows open. I supposed few ppl understood the $prevstateoverrides parameter and moodle will be a better place without it.

+2, thanks a lot Fred

I suppose it would be nice to have some unit tests for section and module hiding. Was it agreed during the hackfest that all bug fixes should have unit tests?

Pushing for integration after added some Unit Tests.

Integrated, thanks Fred.

Sorry, David and I hit the button at about the same time to assign the tester. He was a fraction faster. Giving this back to Ankit.

Works Great Fred,

Thanks for fixing this

Sorry to spam here, but the pointer doesn't change to an arrow (and remains a hand) when hovering the disabled show/hide icons in activities in disabled sections, though the icons are indeed disabled. Not sure if I should open another bug for this.

Thanks for the report Nicolas, but the actions of an activity do not change, even if the section is hidden. And also, clicking on those show/hide should not have any effect on the module activity. (Known issue: it is possible to make an activity visible again by editing its general settings).

Many, many thanks for your effort!

Millions of people will enjoy the results of your work, yay!

Closing as fixed. Ciao

Hi,

We've got lots of problems with section visiblity and cm visiblity in 2.3. I have a feeling its related to this change not being backported and other code being changed to work liks this is working.