Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36424

Wiki in "visible group" has inconsistencies in editing interfaces

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3, 2.4, 2.5, 3.4.3, 3.5, 3.6
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up two groups (group A and group B) and enrol two students in the course & one on each group.
      2. Set up a new wiki and set to 'visible groups' mode.
      3. Log in as a student in group A.
      4. Create a page in HTML format for your group's wiki.
      5. Log in as a student in group B.
      6. Create a page in HTML format for your group's wiki.
      7. After saving your wiki and you're on the "View" tab, confirm that you see the "Edit" tab.
      8. Click on the "Edit" tab and edit the contents of the wiki page then save changes.
      9. Confirm that your changes are successfully saved and reflected in the "View" tab.
      10. Change the group in the drop-down to show group A.
      11. Confirm that the "Edit" tab is not shown for group A's wiki page.
      12. Refresh the page.
      13. Confirm that the "Edit" tab is still not shown
      14. Change the group in the drop-down to show group B.
      15. Confirm that the "Edit" tab is shown for group B's wiki page.
      16. Refresh the page.
      17. Confirm that the "Edit" tab is still shown for group B's wiki page.
      Show
      Set up two groups (group A and group B) and enrol two students in the course & one on each group. Set up a new wiki and set to 'visible groups' mode. Log in as a student in group A. Create a page in HTML format for your group's wiki. Log in as a student in group B. Create a page in HTML format for your group's wiki. After saving your wiki and you're on the " View " tab, confirm that you see the " Edit " tab. Click on the " Edit " tab and edit the contents of the wiki page then save changes. Confirm that your changes are successfully saved and reflected in the " View " tab. Change the group in the drop-down to show group A. Confirm that the " Edit " tab is not shown for group A's wiki page. Refresh the page. Confirm that the " Edit " tab is still not shown Change the group in the drop-down to show group B. Confirm that the " Edit " tab is shown for group B's wiki page. Refresh the page. Confirm that the " Edit " tab is still shown for group B's wiki page.
    • Workaround:
      Hide

      Refresh the page.

      Show
      Refresh the page.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-36424-master

      Description

      Discovered while testing MDL-30478 on the or nightly: Moodle 2.4dev (Build: 20121101).

      As a student in a particular group, when I check a Wiki with a visible group mode activated, there a lag between the state of the correct edit link and the actual shown. If the student is a member of "group A" and see the "group A" wiki page and then select group B as visible page, the edit link remain. If we refresh the page, it disappear. If we select again "group A", they are no longer here. After a refresh, it are here again. Its like the display of the edit link interface is always one step back to the one who should be shown.

      To reproduce:

      1. Set up two groups (group A and group B) and enrol two students in the course & one on each group.
      2. Set up a new wiki and set to 'visible groups' mode.
      3. Log in as student in group A.
      4. Edit a page in your group's wiki - no problem, I can edit it, which is good.
      5. Change the group in the drop-down to show group B.
      => The edit option is visible for this other group's page, it cannot actually edit but the link is shown.
      6. Refresh the page (With the browser).
      => The edit link is no more here (Who is correct).
      7. Change the group in the drop-down to show group A.
      => The edit option is not here for his own group page (Who is incorrect).
      8. Refresh the page (With the browser).
      => The edit link is now here (Who is correct).

      When we correct this one, we may check that the edit link in the navigation block act also this way.

        Attachments

        1. Confirmed_Step11.PNG
          Confirmed_Step11.PNG
          60 kB
        2. Confirmed_Step13.PNG
          Confirmed_Step13.PNG
          57 kB
        3. Confirmed_Step15.PNG
          Confirmed_Step15.PNG
          62 kB
        4. Confirmed_Step17.PNG
          Confirmed_Step17.PNG
          55 kB
        5. Confirmed_Step7.PNG
          Confirmed_Step7.PNG
          55 kB
        6. Confirmed_Step9.PNG
          Confirmed_Step9.PNG
          60 kB

          Activity

            People

            Assignee:
            lucaboesch Luca Bösch
            Reporter:
            leblangi Gilles-Philippe Leblanc
            Peer reviewer:
            Amaia Anabitarte
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            4 Vote for this issue
            Watchers:
            11 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m