Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36447

test_get_file_preview depends on GD, but GD is not a moodle requirement

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Unit tests
    • Labels:
      None

      Description

      When running unit tests without the gd extension, you'll get this failure:

      1) filestoragelib_testcase::test_get_file_preview
      Failed asserting that false is an instance of class "stored_file".

      This is because generate_image_thumbnail will return false if gd is not installed.

      We should either:

      • Make GD a requirement or
      • Make the test skip when GD is not installed

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            poltawski Dan Poltawski
            Integrator:
            Dan Poltawski
            Tester:
            Dan Poltawski
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13