Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.5, 2.3
-
Component/s: Repositories
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-36456-master -
Pull Master Diff URL:
Description
- Go to repositories and enable the Amazon S3 service.
- Enter in '1234' for the Access key and Secret Key
- Visit a course and click to add a file resource.
- Click on 'Add' under 'Select files' to open the file manager
- Click on Amazon S3
Expected result: You should see a friendly message like "Could not connect with current setup information"
Actual result: You get an invalid JSON string error
Gliffy Diagrams
Issue Links
- Testing discovered
-
MDL-34572
Add label for select and text input elements in repository
-
- Closed
-
Activity
Hi Michael, I don't think it should be could be improved, but rather should be.
The error is as follows:
Invalid JSON string
Warning: S3::listBuckets(): [InvalidAccessKeyId] The AWS Access Key Id you provided does not exist in our records. in /var/www/mstorage/im/moodle/repository/s3/S3.php on line 222
Warning: Invalid argument supplied for foreach() in /var/www/mstorage/im/moodle/repository/s3/lib.php on line 101
{"list":[],"path":[
],"manage":false,"dynload":true,"nologin":true,"nosearch":true,"repo_id":12}
There is also a disruptive pop-up. It is not a valid error message to show a user, so it's not like we could improve it by simply wording it better. It needs to be handled correctly.
No drama Mark, I will work on that 
I have created a new generic string which can tell the user that there was a problem while communicating with the plugin. Unfortunately we cannot identify the real problem during the communication with S3, or it would require some logic which might be a bit too much just to display a nice error.
Another option would have been to display the exception from S3, which tells us that the information provided to login are incorrect, that way there is no need to create a new lang string, but I was not convinced that this would be nice enough for the user.
Also I changed the die(json_encode()) because now the repositories handle exception properly.
Looks great to me. Submitting for integration.
Integrated to master 24 and 23, thanks Fred.
It passes, tested in 23 and master
And your fantastic code has met core, hope they become good friends for a long period.
Closing, thanks!
This is error handling related, each repository should handle them better. We might have to create a meta issue for that purpose. Most repositories will badly fail if the access keys are wrong.