Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36456

Amazon S3 invalid JSON string error could be improved

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to repositories and enable the Amazon S3 service.
      2. Enter in '1234' for the Access key and Secret Key
      3. Visit a course and click to add a file resource.
      4. Click on 'Add' under 'Select files' to open the file manager
      5. Click on Amazon S3
      6. Make sure a nice error appear instead of a bad JSON error
      7. Try with JS off, and Make sure you get an exception message.
      Show
      Go to repositories and enable the Amazon S3 service. Enter in '1234' for the Access key and Secret Key Visit a course and click to add a file resource. Click on 'Add' under 'Select files' to open the file manager Click on Amazon S3 Make sure a nice error appear instead of a bad JSON error Try with JS off, and Make sure you get an exception message.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36456-master
    • Pull Master Diff URL:

      Description

      1. Go to repositories and enable the Amazon S3 service.
      2. Enter in '1234' for the Access key and Secret Key
      3. Visit a course and click to add a file resource.
      4. Click on 'Add' under 'Select files' to open the file manager
      5. Click on Amazon S3

      Expected result: You should see a friendly message like "Could not connect with current setup information"

      Actual result: You get an invalid JSON string error

        Attachments

          Issue Links

          Testing discovered

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-34572 Add label for select and text input elements in repository

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Mark Nelson
              Integrator:
              Dan Poltawski
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13