[MDL-36457] JSMin.php file is not GNU GPL compatible - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Main Branch:
w46_~~MDL-36457~~_m24_jsmin
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/master...w46_MDL-36457_m24_jsmin
URL:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692626
Testing Instructions:
Hide

1/ make sure JS caching is enabled
2/ purge caches
3/ test Moodle UI that is using Javascript - use JS browser console and watch for errors

Examples of UI areas:

enrolments

roles UI

file picker

navigation

forms

etc.
Show
1/ make sure JS caching is enabled 2/ purge caches 3/ test Moodle UI that is using Javascript - use JS browser console and watch for errors Examples of UI areas: enrolments roles UI file picker navigation forms etc.

In /lib/minify/lib/JSMin.php we have some code that Debian doesn't like, because the license is: "The Software shall be used for Good, not Evil.""

The unmaintained code is from here: https://github.com/rgrove/jsmin-php

And even the author recommends alternatives there. Let's switch to one.

caused a regression

MDL-36772 SCORM activities no longer seem to commit the results.

has been marked as being related by

MDL-36463 backport minify from 2.4 to older stable branches

Participants:: Andrew Lyons, Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Hubert Chathi, Jason Fowler, Martin Dougiamas, Petr Skoda