Moodle
  1. Moodle
  2. MDL-36487

add IE standards http header to each page

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Rank:
      45943

      Description

      This might help with kicking of IE into the sanity mode...

      Matteo Scaramuccia added a comment - 09/Nov/12 4:43 PM
      HTH: http://msdn.microsoft.com/en-us/library/ff955275%28v=vs.85%29.aspx

      Web developers can also specify a document mode by including instructions in a meta element or HTTP response header:

      Webpages that include a meta element (see [HTML]) with an http-equivalent value of X-UA-Compatible.
      Webpages that are served with an HTTP header named "X-UA-Compatible".
      If both of these instructions are sent, the developer's preference (meta element) takes precedence over the web server setting (HTTP header).

      It's not clear - at least to me - if it is better but since HTTP Headers are loaded before anything coming with the payload, it should IMHO works better (read, more stable expected results) without breaking the possibility for theme devs to override that setting.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Does this need to be reversable? (see also scorm thingy?)

          Show
          Dan Poltawski added a comment - Does this need to be reversable? (see also scorm thingy?)
          Hide
          Petr Škoda added a comment -

          Adding DanM as watcher: what is the current status of SCORM+IE? How does it deal with latest IE versions?

          Show
          Petr Škoda added a comment - Adding DanM as watcher: what is the current status of SCORM+IE? How does it deal with latest IE versions?
          Hide
          Petr Škoda added a comment -

          Thanks Dan, I have added one more commit that does not set the header on SCORM player page or any other page that sets custom X-UA-Compatible additional head stuff.

          Show
          Petr Škoda added a comment - Thanks Dan, I have added one more commit that does not set the header on SCORM player page or any other page that sets custom X-UA-Compatible additional head stuff.
          Hide
          Dan Marsden added a comment -

          I need to rip out that SCORM hack - it doesn't work as it has to be the first item after the <body> tag to work correctly.

          I also thought certain versions of IE ignored X-UA when passed in the http headers - they only worked when in the actual content of the page? - I'd be interested to know if anyone knows which browser versions work when using http headers.

          Show
          Dan Marsden added a comment - I need to rip out that SCORM hack - it doesn't work as it has to be the first item after the <body> tag to work correctly. I also thought certain versions of IE ignored X-UA when passed in the http headers - they only worked when in the actual content of the page? - I'd be interested to know if anyone knows which browser versions work when using http headers.
          Hide
          Dan Poltawski added a comment -

          You'd think that setting the http header would be the most robust solution for this eh!

          Show
          Dan Poltawski added a comment - You'd think that setting the http header would be the most robust solution for this eh!
          Hide
          Dan Poltawski added a comment -

          I'm not entirely convinced by the use of the additionalhtmlhead tag to control this. I think we should probably introduce an option/constant or something for it.

          But this is existing behaviour, so we can address that in a new issue.

          Show
          Dan Poltawski added a comment - I'm not entirely convinced by the use of the additionalhtmlhead tag to control this. I think we should probably introduce an option/constant or something for it. But this is existing behaviour, so we can address that in a new issue.
          Hide
          Dan Poltawski added a comment - - edited

          Reading about this, it seems the meta tag can break validation, and people seem to recomend only adding the header. Maybe we should be rid of the meta tag:
          https://github.com/h5bp/html5-boilerplate/blob/master/doc/html.md#x-ua-compatible

          Look at this 'handy' flowchart: http://i.stack.imgur.com/e5gPv.png

          Show
          Dan Poltawski added a comment - - edited Reading about this, it seems the meta tag can break validation, and people seem to recomend only adding the header. Maybe we should be rid of the meta tag: https://github.com/h5bp/html5-boilerplate/blob/master/doc/html.md#x-ua-compatible Look at this 'handy' flowchart: http://i.stack.imgur.com/e5gPv.png
          Hide
          Petr Škoda added a comment -

          Oh my, IE really deserves to die in a fast but still extremely painful way.

          I agree we should remove the new things from the HTML output and let themes add it if necessary. Could you please create a new issue for that?

          Show
          Petr Škoda added a comment - Oh my, IE really deserves to die in a fast but still extremely painful way. I agree we should remove the new things from the HTML output and let themes add it if necessary. Could you please create a new issue for that?
          Hide
          Michael de Raadt added a comment -

          I've tested this in IE8 and IE9. I tested it on IE10 in a Win8 VM, but that was a beta version. I'm installing a current IE10 in Win7 and I will test it there.

          Show
          Michael de Raadt added a comment - I've tested this in IE8 and IE9. I tested it on IE10 in a Win8 VM, but that was a beta version. I'm installing a current IE10 in Win7 and I will test it there.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in IE8, IE9 and IE10.

          Standard mode appeared consistently around the site and TinyMCE plugins worked as expected.

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in IE8, IE9 and IE10. Standard mode appeared consistently around the site and TinyMCE plugins worked as expected.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many, many thanks for your effort!

          Millions of people will enjoy the results of your work, yay!

          Closing as fixed. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: