Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36490

Standard theme border-radius on .generalbox

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.4.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test Instructions

      1. Navigate to Site Administration > Development > Purge all caches and Purge all caches
      2. View the div#notice element on the Purge all caches page, itself a div.generalbox, and note that bottom left and bottom right corners now have the same border-radius as top right and top left corners.
        1. Alternatively, navigate to Site Administration > Notifications; there are usually a few div.generalbox elements there upon which you can verify the change.
        2. Alternatively, view or create a Web page resource and then view the resource. The content is presented inside a div.generalbox. All corners should have the same border-radius.
      Show
      Test Instructions Navigate to Site Administration > Development > Purge all caches and Purge all caches View the div#notice element on the Purge all caches page, itself a div.generalbox, and note that bottom left and bottom right corners now have the same border-radius as top right and top left corners. Alternatively, navigate to Site Administration > Notifications; there are usually a few div.generalbox elements there upon which you can verify the change. Alternatively, view or create a Web page resource and then view the resource. The content is presented inside a div.generalbox. All corners should have the same border-radius.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36490_master

      Description

      The standard theme puts a border-radius on .generalbox objects which has a different radius on the bottom corners than the top corners. In some contexts this looks fine, and it makes sense why this was done. In some cases, especially when there is more than one .generalbox in the main content area, it looks kind of strange.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            agroshek Amy Groshek added a comment -

            As-is screenshot

            Show
            agroshek Amy Groshek added a comment - As-is screenshot
            Hide
            agroshek Amy Groshek added a comment -

            Screenshot with border-radius universal 3px

            Show
            agroshek Amy Groshek added a comment - Screenshot with border-radius universal 3px
            Hide
            agroshek Amy Groshek added a comment - - edited

            I did not add the vendor prefixes. They aren't necessary for recent versions of Webkit or Moz. IE9 also uses plain old border-radius.

            Show
            agroshek Amy Groshek added a comment - - edited I did not add the vendor prefixes. They aren't necessary for recent versions of Webkit or Moz. IE9 also uses plain old border-radius.
            Hide
            lazydaisy Mary Evans added a comment -

            Thanks Amy, I'll see what I can do.

            Show
            lazydaisy Mary Evans added a comment - Thanks Amy, I'll see what I can do.
            Hide
            agroshek Amy Groshek added a comment -

            Hi Mary! Thank you!

            Show
            agroshek Amy Groshek added a comment - Hi Mary! Thank you!
            Hide
            lazydaisy Mary Evans added a comment - - edited

            Hi Amy,
            If you have a few minutes to spare can you add some basic Test Instructions as I'm not too sure how you got that page with all the different headings which does show off the odd looking boxes!

            Thanks

            Show
            lazydaisy Mary Evans added a comment - - edited Hi Amy, If you have a few minutes to spare can you add some basic Test Instructions as I'm not too sure how you got that page with all the different headings which does show off the odd looking boxes! Thanks
            Hide
            lazydaisy Mary Evans added a comment -

            Re-based and new M24 branch added.

            Show
            lazydaisy Mary Evans added a comment - Re-based and new M24 branch added.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mary, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Mary,

            All borders are same on div.generalbox box.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Mary, All borders are same on div.generalbox box.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Changes are now upstream, thanks for your collaboration!

            If you are going to have any celebration next days, enjoy with your gang, if not, too!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao
            Hide
            agroshek Amy Groshek added a comment -

            Thanks @Eloy! You have a great holidays too! I just pulled the new updates and I'm so excited to see this change. Looks great.

            Show
            agroshek Amy Groshek added a comment - Thanks @Eloy! You have a great holidays too! I just pulled the new updates and I'm so excited to see this change. Looks great.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13