Moodle
  1. Moodle
  2. MDL-36511

"Completion starts on enrolment" cannot be disabled

    Details

    • Rank:
      45973

      Description

      The tickbox in course settings for "Completion starts on enrolment" cannot be turned off.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for putting that forward. Hopefully we can get this peer reviewed and integrated soon.

          Show
          Michael de Raadt added a comment - Thanks for putting that forward. Hopefully we can get this peer reviewed and integrated soon.
          Hide
          Ankit Agarwal added a comment -

          Hi Aaron,
          Thanks for working on this issue.
          Patch looks great. Feel free to submit for integration. This should also be back ported imo.
          However this raises more serious questions, as checkbox is used all over moodle and am not sure how many of these places count the fact that no value is set for the element when its not checked.

          I will report a generic issue to review this.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Aaron, Thanks for working on this issue. Patch looks great. Feel free to submit for integration. This should also be back ported imo. However this raises more serious questions, as checkbox is used all over moodle and am not sure how many of these places count the fact that no value is set for the element when its not checked. I will report a generic issue to review this. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Aaron, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Aaron, this has been integrated now.
          Hide
          Rossiani Wijaya added a comment -

          This works as expected.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This works as expected. Test passed.
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: